-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap gce-conformance on sig-release-master-blocking from kubetest to kubetest2 #21180
Conversation
dba45e9
to
052c3f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/area conformance
/cc @dims @johnbelamaric
as FYI
I compared results of latest runs
The difference in number of tests passed is due to the e2e.go
suite having 13 steps, where kubetest2's (unamed) suite has 4 steps
Comparing durations on testgrid:
Overall
is about 10min longer for kubetest2, but Test
is about 10min shortee for kubetest2. Turns out this is due to the fact that there is a kubetest2.Build
stage.
The kubetest2 job hasn't been passing for a full two weeks, but I see nothing in its history to indicate that it's providing lower quality signal than the job it's replacing.
So, suggestions for followup:
- kubetest2 job should download pre-built binaries from
k8s-release-dev
bucket - kubetest2 should give its "meta" suite a name, maybe
kubetest2
/approve
/lgtm
/hold
for comment, I'm gonna go ping release team
/assign @thejoycekung @palnabarun I'll remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks @amwat!
+1 ack on the differences
|
No, the vast majority of jobs targeting any branch use the existing uploads of this. It adds a little latency (the time it takes us to (I need to fix this for KIND, but it was not subsuming an existing job, and for some time we were intentionally using different builds in some jobs). |
Do you have a spyglass link for this? I checked one of our test runs and the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The job looks stable, and I think it's super awesome we're moving away from bootstrap. Thanks y'all!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amwat, hasheddan, spiffxp, thejoycekung The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tracked in kubernetes-sigs/kubetest2#107 |
/hold cancel |
@amwat: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
First of many! No bootstrap, no scenarios, no kubetest :)
xref: kubernetes/enhancements#2464
The kubetest2 gce-conformance job has been stable for a while:
https://testgrid.k8s.io/conformance-all#Conformance%20-%20GCE%20-%20master%20-%20kubetest2
the old job will still be visible at: https://testgrid.k8s.io/conformance-all#Conformance%20-%20GCE%20-%20master
will not be turned down yet
Only targetting master, older release branches will still use kubetest based jobs.
/cc @BenTheElder @spiffxp
/cc @kubernetes/ci-signal
/cc @kubernetes/sig-release