Add classname attr to the JUnit test case and add a flag to allow skipping test junit report #105
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
There was a problem hiding this comment.
I wouldn't want to mess with the name too much as it invalidates a lot of testgrid history.
ref: kubernetes/test-infra#21180 (comment)
I think filtering out the kubetest2 specific entries can be done by whatever is post processing it by many other means? (sorting and relying on capitalized alphabetical order is not the most ideal)
chizhg
changed the title
k8s-ci-robot
added
size/S
That makes total sense. I've reverted the change in my PR and updated the commit message accordingly. |
k8s-ci-robot
added
size/M
chizhg
changed the title
pkg/app/cmd.go
Outdated
| @@ -199,6 +200,7 @@ func (o *options) bindFlags(flags *pflag.FlagSet) { | |||
| flags.BoolVar(&o.up, "up", false, "provision the test cluster") | |||
| flags.BoolVar(&o.down, "down", false, "tear down the test cluster") | |||
| flags.StringVar(&o.test, "test", "", "test type to run, if unset no tests will run") | |||
| flags.BoolVar(&o.skipTestJUnitReport, "skip-test-junit-report", false, "skip reporting the test result as a JUnit test case") | |||
There was a problem hiding this comment.
Is "test" a necessary distinction here?
Vs "skip-junit-report", "skip reporting kubetest2 steps to junit.xml", etc
There was a problem hiding this comment.
IIUC the intention is to only skip adding the junit entry for the kubetest2.Test() step. build, up, down will still show.
It's not too ideal but since we have explicit tester binaries I can see use cases where it should be treated specially.
There was a problem hiding this comment.
Thanks @amwat . Yes, that is the intention for this change.
k8s-ci-robot
added
the
approved
…pping test junit report
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amwat, chizhg, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
classnameattribute to the JUnit test case to show on Spyglass, this will fix testsuite name does not show up in spyglass JUnit lens #107TestJUnit result will be redundant. So add an extra flag--skip-test-junit-reportto allow skipping reporting the JUnit test result. This will partially fix The error message in the JUnit xml result is not informative #58.