-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kind job updates: update test target, add more branches #20765
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -242,6 +242,100 @@ presubmits: | |||
# during the tests more like 3-20m is used | |||
cpu: 2000m | |||
# mimic pull-kubernetes-e2e-kind, but using kind built in this PR | |||
- always_run: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- copy from k/k forked job
- add extra ref for the kubernetes branch
- update
name
field to match kind presubmits - update container
command
to cd to k/k and run e2e.sh instead of curl + e2e-k8s.sh - drop
cluster
field since it's unclear if we're allowed to use that cluster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aha: the missing piece is to also drop the branches
field entirely, as we want it to run on whatever the kind development branch is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@BenTheElder: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
preset-dind-enabled: "true" | ||
preset-kind-volume-mounts: "true" | ||
name: pull-kind-e2e-kubernetes-1-20 | ||
path_alias: k8s.io/kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in followup
extra_refs: | ||
- org: kubernetes | ||
repo: kubernetes | ||
base_ref: release-1.189 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in followup
preset-dind-enabled: "true" | ||
preset-kind-volume-mounts: "true" | ||
name: pull-kind-e2e-kubernetes-1-19 | ||
path_alias: k8s.io/kubernetes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in followup
followup #20769 |
1.19/1.20 have been an oversight.
unit => test happened when we made a distinction for integration tests.
these are overdue.