Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kind job updates: update test target, add more branches #20765

Merged
merged 2 commits into from
Feb 5, 2021

Conversation

BenTheElder
Copy link
Member

1.19/1.20 have been an oversight.
unit => test happened when we made a distinction for integration tests.
these are overdue.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 5, 2021
@BenTheElder BenTheElder mentioned this pull request Feb 5, 2021
@@ -242,6 +242,100 @@ presubmits:
# during the tests more like 3-20m is used
cpu: 2000m
# mimic pull-kubernetes-e2e-kind, but using kind built in this PR
- always_run: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • copy from k/k forked job
  • add extra ref for the kubernetes branch
  • update name field to match kind presubmits
  • update container command to cd to k/k and run e2e.sh instead of curl + e2e-k8s.sh
  • drop cluster field since it's unclear if we're allowed to use that cluster

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aha: the missing piece is to also drop the branches field entirely, as we want it to run on whatever the kind development branch is.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@amwat amwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2f90745 into kubernetes:master Feb 5, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 5, 2021
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kind-postsubmits.yaml using file config/jobs/kubernetes-sigs/kind/kind-postsubmits.yaml
  • key kind-presubmits.yaml using file config/jobs/kubernetes-sigs/kind/kind-presubmits.yaml
  • key kind.yaml using file config/jobs/kubernetes-sigs/kind/kind.yaml

In response to this:

1.19/1.20 have been an oversight.
unit => test happened when we made a distinction for integration tests.
these are overdue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder BenTheElder deleted the kind-job-updates branch February 6, 2021 00:06
preset-dind-enabled: "true"
preset-kind-volume-mounts: "true"
name: pull-kind-e2e-kubernetes-1-20
path_alias: k8s.io/kubernetes
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in followup

extra_refs:
- org: kubernetes
repo: kubernetes
base_ref: release-1.189
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in followup

preset-dind-enabled: "true"
preset-kind-volume-mounts: "true"
name: pull-kind-e2e-kubernetes-1-19
path_alias: k8s.io/kubernetes
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in followup

@BenTheElder
Copy link
Member Author

followup #20769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants