-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kind job updates: update test target, add more branches #20765
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,7 +16,7 @@ presubmits: | |
# we need privileged mode in order to do docker in docker | ||
securityContext: | ||
privileged: true | ||
- name: pull-kind-unit | ||
- name: pull-kind-test | ||
decorate: true | ||
path_alias: sigs.k8s.io/kind | ||
always_run: true | ||
|
@@ -28,7 +28,7 @@ presubmits: | |
command: | ||
- wrapper.sh | ||
- make | ||
- unit | ||
- test | ||
# we need privileged mode in order to do docker in docker | ||
securityContext: | ||
privileged: true | ||
|
@@ -242,6 +242,100 @@ presubmits: | |
# during the tests more like 3-20m is used | ||
cpu: 2000m | ||
# mimic pull-kubernetes-e2e-kind, but using kind built in this PR | ||
- always_run: true | ||
branches: | ||
- release-1.20 | ||
decorate: true | ||
decoration_config: | ||
grace_period: 15m0s | ||
timeout: 1h0m0s | ||
extra_refs: | ||
- org: kubernetes | ||
repo: kubernetes | ||
base_ref: release-1.20 | ||
path_alias: k8s.io/kubernetes | ||
labels: | ||
preset-bazel-remote-cache-enabled: "true" | ||
preset-bazel-scratch-dir: "true" | ||
preset-dind-enabled: "true" | ||
preset-kind-volume-mounts: "true" | ||
name: pull-kind-e2e-kubernetes-1-20 | ||
path_alias: k8s.io/kubernetes | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. wrong There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed in followup |
||
spec: | ||
containers: | ||
- command: | ||
- wrapper.sh | ||
- bash | ||
- -c | ||
- cd ./../../k8s.io/kubernetes && ./../../sigs.k8s.io/kind/hack/ci/e2e.sh | ||
env: | ||
- name: FOCUS | ||
value: . | ||
- name: SKIP | ||
value: \[Slow\]|\[Disruptive\]|\[Flaky\]|\[Feature:.+\]|PodSecurityPolicy|LoadBalancer|load.balancer|Simple.pod.should.support.exec.through.an.HTTP.proxy|subPath.should.support.existing|NFS|nfs|inline.execution.and.attach|should.be.rejected.when.no.endpoints.exist | ||
- name: PARALLEL | ||
value: "true" | ||
- name: BUILD_TYPE | ||
value: bazel | ||
image: gcr.io/k8s-testimages/krte:v20210204-b06ec78-1.20 | ||
name: "" | ||
resources: | ||
limits: | ||
cpu: "4" | ||
memory: 9000Mi | ||
requests: | ||
cpu: "4" | ||
memory: 9000Mi | ||
securityContext: | ||
privileged: true | ||
# mimic pull-kubernetes-e2e-kind, but using kind built in this PR | ||
- always_run: true | ||
branches: | ||
- release-1.19 | ||
extra_refs: | ||
- org: kubernetes | ||
repo: kubernetes | ||
base_ref: release-1.189 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. typo There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed in followup |
||
path_alias: k8s.io/kubernetes | ||
decorate: true | ||
decoration_config: | ||
grace_period: 15m0s | ||
timeout: 1h0m0s | ||
labels: | ||
preset-bazel-remote-cache-enabled: "true" | ||
preset-bazel-scratch-dir: "true" | ||
preset-dind-enabled: "true" | ||
preset-kind-volume-mounts: "true" | ||
name: pull-kind-e2e-kubernetes-1-19 | ||
path_alias: k8s.io/kubernetes | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. wrong There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed in followup |
||
spec: | ||
containers: | ||
- command: | ||
- wrapper.sh | ||
- bash | ||
- -c | ||
- cd ./../../k8s.io/kubernetes && ./../../sigs.k8s.io/kind/hack/ci/e2e.sh | ||
env: | ||
- name: FOCUS | ||
value: . | ||
- name: SKIP | ||
value: \[Slow\]|\[Disruptive\]|\[Flaky\]|\[Feature:.+\]|PodSecurityPolicy|LoadBalancer|load.balancer|Simple.pod.should.support.exec.through.an.HTTP.proxy|subPath.should.support.existing|Conntrack|udp|UDP|NFS|nfs|inline.execution.and.attach|should.be.rejected.when.no.endpoints.exist | ||
- name: PARALLEL | ||
value: "true" | ||
- name: BUILD_TYPE | ||
value: bazel | ||
image: gcr.io/k8s-testimages/krte:v20210204-3eaec9a-1.19 | ||
name: "" | ||
resources: | ||
limits: | ||
cpu: "4" | ||
memory: 9000Mi | ||
requests: | ||
cpu: "4" | ||
memory: 9000Mi | ||
securityContext: | ||
privileged: true | ||
# mimic pull-kubernetes-e2e-kind, but using kind built in this PR | ||
- name: pull-kind-e2e-kubernetes-1-18 | ||
always_run: true | ||
labels: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name
field to match kind presubmitscommand
to cd to k/k and run e2e.sh instead of curl + e2e-k8s.shcluster
field since it's unclear if we're allowed to use that clusterThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aha: the missing piece is to also drop the
branches
field entirely, as we want it to run on whatever the kind development branch is.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#20770