Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kind: Add 1.19 jobs #19166

Closed
wants to merge 1 commit into from
Closed

kind: Add 1.19 jobs #19166

wants to merge 1 commit into from

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Sep 9, 2020 •
edited
Loading

Adding 1.19 jobs
ref: failing tests in kubernetes-sigs/kind#1841.

Signed-off-by: Stephen Augustus saugustus@vmware.com

/assign @BenTheElder

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 9, 2020
@k8s-ci-robot k8s-ci-robot requested review from amwat and aojea September 9, 2020 21:35
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 9, 2020
@justaugustus justaugustus mentioned this pull request Sep 9, 2020
Merged
@BenTheElder
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2020
@BenTheElder
Copy link
Member

we still support these older versions

@justaugustus
Copy link
Member Author

Chatted w/ Ben here: https://kubernetes.slack.com/archives/C2C40FMNF/p1599690322163000?thread_ts=1599690270.162700&cid=C2C40FMNF
Will drop the drops so this only adds the 1.19 jobs, once #19168 has merged.

@justaugustus
kind: Add 1.19 jobs
7ce429c 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justaugustus
To complete the pull request process, please assign bentheelder
You can assign the PR to them by writing /assign @bentheelder in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus justaugustus changed the title kind: Add 1.19 jobs, drop EOL release jobs (1.16, 1.15) kind: Add 1.19 jobs Sep 9, 2020
BenTheElder
BenTheElder reviewed Sep 9, 2020
View reviewed changes
config/jobs/kubernetes-sigs/kind/kind-presubmits.yaml
# NOTE: changes should filter down to pull-kubernetes-e2e-kind-canary
# and then pull-kubernetes-e2e-kind
- name: SKIP
value: \[Slow\]|\[Disruptive\]|\[Flaky\]|\[Feature:.+\]|PodSecurityPolicy|LoadBalancer|load.balancer|In-tree.Volumes.\[Driver:.nfs\]|PersistentVolumes.NFS|Network.should.set.TCP.CLOSE_WAIT.timeout|Simple.pod.should.support.exec.through.an.HTTP.proxy|subPath.should.support.existing|should.provide.basic.identity|\[NodeFeature:PodReadinessGate\]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this matches upstream 1.19?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's the same we have for 1.18 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-infra/config/jobs/kubernetes/sig-release/release-branch-jobs/1.19.yaml

Line 1432 in 1f6f590

value: \[Slow\]|\[Disruptive\]|\[Flaky\]|\[Feature:.+\]|PodSecurityPolicy|LoadBalancer|load.balancer|Simple.pod.should.support.exec.through.an.HTTP.proxy|subPath.should.support.existing|Conntrack|udp|UDP|NFS|nfs|inline.execution.and.attach|should.be.rejected.when.no.endpoints.exist

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

someday we will move this out of prow config ..

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 9, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 8, 2021
@spiffxp
Copy link
Member

spiffxp commented Jan 19, 2021

/remove-lifecycle rotten
/test pull-test-infra-integration
#20498 (comment)

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 19, 2021
@BenTheElder
Copy link
Member

#20765

@BenTheElder BenTheElder closed this Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@amwat amwat Awaiting requested review from amwat

@aojea aojea Awaiting requested review from aojea

Assignees

@BenTheElder BenTheElder

Labels
area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@justaugustus @BenTheElder @k8s-ci-robot @fejta-bot @spiffxp @aojea