vSphere CSI Driver 2.0 #151

divyenpatel · 2020-04-06T19:01:55Z

What this PR does / why we need it:

Added persistent volume support for Tanzu Kubernetes Grid Cluster (Guest Cluster) - https://blogs.vmware.com/vsphere/2020/03/vsphere-7-tanzu-kubernetes-clusters.html
Added persistent volume support for Project Pacific (Supervisor Kubernetes Cluster) - https://blogs.vmware.com/vsphere/2019/08/introducing-project-pacific.html
Added support for ReadWriteMany volumes using vSAN file services on upstream vanilla Kubernetes. - https://blogs.vmware.com/virtualblocks/2020/03/12/cloud-native-storage-and-vsan-file-services-integration/
Added Extend Volume feature for vSphere Block Volume on upstream vanilla Kubernetes.
Added support for enabling leader election to ensure High Availability for vSphere CSI driver.
Enhanced driver to ensure volume operations are idempotent.
Enhanced driver logging and debuggability with contextual log tracing.
Added end to end test cases for newly added features.
Several bug fixes and major performance improvements.

Which issue this PR fixes
fixes #136
fixes #103
fixes #93
fixes #138
fixes #100
fixes #55

Special notes for your reviewer:

This is a huge Pull Request with 243 commits, authored by many developers (@divyenpatel, @BaluDontu, @RaunakShah, @chethanv28, @yuyiying, @lipingxue, @shalini-b, @shreesha21, @xing-yang, @SandeepPissay, @subramanian-neelakantan @sashrith and @ankitvaidya)

Most of the commits were already reviewed internally by VMware Engineers.

Please focus on reviewing following additional commits

d7ba641 - Removed - unnecessary use of fmt.Sprintf (S1039)
e3276ea - should omit comparison to bool constant
8942cc1 - Fixed – unused value of variables, unused variables and unused functions
e714e0f - Fixed: should use make(map[string]string) instead (S101)
2f3e6e0 - staticcheck fixes
ab5405e - fixing ReloadConfiguration for staticcheck verification
9cdc1da - fixed check-vet failures
0793d67 - fixed markdown linter check failures
3babeb0 - setting updateStrategy to RollingUpdate for vsphere-csi-controller deployment
00e1935 - fixed integration-unit-test
fc1ed68 - changing maintainers of driver docker images

Release note:

vSphere CSI Driver 2.0

k8s-ci-robot · 2020-04-06T19:02:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyenpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [divyenpatel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2020-04-06T19:05:05Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Makefile

hack/check-lint.sh

hack/verify-golint.sh

ankitvaidya · 2020-04-07T06:17:52Z

I signed it

sashrith · 2020-04-07T06:30:12Z

Signed it

divyenpatel · 2020-04-07T06:42:33Z

/retest

divyenpatel · 2020-04-07T06:47:42Z

/check-cla

divyenpatel · 2020-04-07T13:33:09Z

/check-cla

re-arranged code to rebase with internal repository

…te Volume Implementation

…te Delete Implementation

… modules

…NDS to syncer container. PodListener gRPC service will only be run when WCP is enabled

…e + Implement WCP CSI Detach

r-shreesha · 2020-04-07T16:13:55Z

I signed it

r-shreesha · 2020-04-07T16:57:11Z

I signed it

manifests/vsphere-67u3/vanilla/deploy/vsphere-csi-controller-deployment.yaml

xing-yang · 2020-04-07T17:22:30Z

Just 1 nit. Looks good other than that.

xing-yang · 2020-04-07T17:43:09Z

/lgtm

SandeepPissay · 2020-04-07T18:17:44Z

I glanced through the code changes in all the commits mentioned in the PR description and I did not find any obvious issues. Given that most of the code changes are internally reviewed this PR is good to merge.

SandeepPissay · 2020-04-07T18:17:53Z

/lgtm

alex1989hu · 2020-04-07T18:40:36Z

manifests/vsphere-7.0/vanilla/deploy/vsphere-csi-node-ds.yaml

+        - name: registration-dir
+          mountPath: /registration
+      - name: vsphere-csi-node
+        image: vmware/vsphere-csi:<vsphere_csi_ver>


What is the plan with <vsphere_csi_ver>? This should be addressed in upcoming PR, cannot be used otherwise.

@alex1989hu driver images in the YAML will be replaced with following when release v.2.0.0 is cut.

gcr.io/cloud-provider-vsphere/csi/release/driver:v2.0.0 gcr.io/cloud-provider-vsphere/csi/release/syncer:v2.0.0

@divyenpatel when are the container images available?

I also hope to learn that please. I urgently need a working image.

working images, but not final release:

gcr.io/cloud-provider-vsphere/csi/ci/driver:v1.0.2-265-gbaaccdf gcr.io/cloud-provider-vsphere/csi/ci/syncer:v1.0.2-265-gbaaccdf

I also update this information in my own issue: #154 . I tested the latest image and it worked on kubernetes 1.16.6 with vSphere 7.0

alex1989hu · 2020-04-07T18:40:56Z

manifests/vsphere-67u3/vanilla/deploy/vsphere-csi-controller-deployment.yaml

          env:
            - name: ADDRESS
              value: /csi/csi.sock
          volumeMounts:
            - mountPath: /csi
              name: socket-dir
        - name: vsphere-csi-controller
-          image: gcr.io/cloud-provider-vsphere/csi/release/driver:v1.0.2
+          image: vmware/vsphere-csi:<vsphere_csi_ver>


What is the plan with <vsphere_csi_ver>? This should be addressed in upcoming PR, cannot be used otherwise.

alex1989hu · 2020-04-07T18:41:01Z

manifests/vsphere-67u3/vanilla/deploy/vsphere-csi-node-ds.yaml

+        - name: registration-dir
+          mountPath: /registration
+      - name: vsphere-csi-node
+        image: vmware/vsphere-csi:<vsphere_csi_ver>


What is the plan with <vsphere_csi_ver>? This should be addressed in upcoming PR, cannot be used otherwise.

alex1989hu · 2020-04-07T18:41:12Z

manifests/vsphere-7.0/supervisorcluster/k8s-1.15/deploy/vsphere-csi-controller-deployment.yaml

+            - name: socket-dir
+              mountPath: /var/lib/csi/sockets/pluginproxy/
+        - name: vsphere-csi-controller
+          image: vmware/vsphere-csi:<vsphere_csi_ver>


What is the plan with <vsphere_csi_ver>? This should be addressed in upcoming PR, cannot be used otherwise.

alex1989hu · 2020-04-07T18:41:16Z

manifests/vsphere-7.0/vanilla/deploy/vsphere-csi-controller-deployment.yaml

+            - mountPath: /csi
+              name: socket-dir
+        - name: vsphere-csi-controller
+          image: vmware/vsphere-csi:<vsphere_csi_ver>


What is the plan with <vsphere_csi_ver>? This should be addressed in upcoming PR, cannot be used otherwise.

alex1989hu · 2020-04-08T06:21:39Z

go.mod

@@ -1,111 +1,98 @@
 module sigs.k8s.io/vsphere-csi-driver


I made a PR to fix v2: #156

nickvth · 2020-04-10T07:49:40Z

Please add online resizing

33s         Warning   ExternalExpanding        persistentvolumeclaim/grafana   Ignoring the PVC: didn't find a plugin capable of expanding the volume; waiting for an external controller to process this PVC.
9s          Normal    Resizing                 persistentvolumeclaim/grafana   External resizer is resizing volume pvc-c01f75b5-28ff-4f25-8979-b94416f540a2
20s         Warning   VolumeResizeFailed       persistentvolumeclaim/grafana   resize volume pvc-c01f75b5-28ff-4f25-8979-b94416f540a2 failed: rpc error: code = FailedPrecondition desc = failed to expand volume: "713dd25b-56cb-4092-a593-8acd93651b99" to size: 12288. Volume is attached to node "42128e4f-aa14-bedc-a7a5-69a28e4c8d1a". Only offline volume expansion is supported

vSphere CSI Driver 2.0

divyenpatel requested review from xing-yang and SandeepPissay April 6, 2020 19:01

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 6, 2020

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 6, 2020

RaunakShah reviewed Apr 6, 2020

View reviewed changes

Makefile Outdated Show resolved Hide resolved

hack/check-lint.sh Outdated Show resolved Hide resolved

hack/verify-golint.sh Outdated Show resolved Hide resolved

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 7, 2020

divyenpatel and others added 15 commits April 7, 2020 07:04

re-arranged code to rebase with internal repository

24eae5c

re-arranged code to rebase with internal repository

WCP CSI Controller Init Implementation

a28c87d

WCP CSI Create Volume implementation

392e1ad

Add support for Unit tests and Integration tests for WCP and its Crea…

874e026

…te Volume Implementation

Fix Simulator tests

7d8ffcf

WCP Delete Volume Implementation

75ef73b

Add support for Unit tests and Integration tests for WCP and its Crea…

05b663c

…te Delete Implementation

Common types to be used by Pod Listener and Metadatasyncer/FullSyncer…

a5cd7d6

… modules

Define Pod listener gRPC service

ca3596c

Implement the Pod listener gRPC service

b4f68d4

Add a new flag X_CSI_CONTROLLER_TYPE and X_CSI_POD_POLL_INTERVAL_SECO…

51e5d4c

…NDS to syncer container. PodListener gRPC service will only be run when WCP is enabled

Implement WCP CSI Attach by integrating with Pod Listener gRPC servic…

e7b7c5e

…e + Implement WCP CSI Detach

Update unit test to reflect new metadatasyncer struct

2bcde79

Minor fix metadata syncer unit test

a683ea6

Implement WCP Guestcluster CSI Controller Initialization

9122a3d

This was referenced Apr 7, 2020

Fix PVUpdate pre check #139

Closed

[WIP] Deploy CSI driver as a deployment and support multi master & leader e… #72

Closed

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 7, 2020

xing-yang reviewed Apr 7, 2020

View reviewed changes

manifests/vsphere-67u3/vanilla/deploy/vsphere-csi-controller-deployment.yaml Outdated Show resolved Hide resolved

addressed review comments

1db734c

divyenpatel added this to the v2.0.0 milestone Apr 7, 2020

k8s-ci-robot assigned xing-yang Apr 7, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2020

k8s-ci-robot merged commit 51199e1 into kubernetes-sigs:master Apr 7, 2020

alex1989hu reviewed Apr 7, 2020

View reviewed changes

alex1989hu mentioned this pull request Apr 8, 2020

Wrong image tag in vsphere-csi-controller #154

Closed

alex1989hu reviewed Apr 8, 2020

View reviewed changes

go.mod

@@ -1,111 +1,98 @@

module sigs.k8s.io/vsphere-csi-driver

Copy link

Contributor

alex1989hu Apr 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a PR to fix v2: #156

divyenpatel mentioned this pull request Apr 9, 2020

Issue with vsphere-csi-controller-deployment.yaml #157

Closed

pierreyves-lebrun mentioned this pull request Apr 10, 2020

Add vSphere external cloud provider kubernetes-sigs/kubespray#5861

Closed

nickvth mentioned this pull request Apr 10, 2020

Please add online resizing in CSI 2.x #162

Closed

divyenpatel mentioned this pull request Apr 16, 2020

remove mounting vsphere-config-secret in vsphere-csi-node daemonset #181

Merged

RaunakShah pushed a commit to RaunakShah/vsphere-csi-driver that referenced this pull request Jul 9, 2020

Merge pull request kubernetes-sigs#151 from divyenpatel/release-2.0

a2b306a

vSphere CSI Driver 2.0

lebenitza mentioned this pull request Sep 4, 2020

Support for vSphere storage Container Storage Interface (CSI) rancher/rke#1733

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

vSphere CSI Driver 2.0 #151

vSphere CSI Driver 2.0 #151

divyenpatel commented Apr 6, 2020 •

edited

Loading

k8s-ci-robot commented Apr 6, 2020

k8s-ci-robot commented Apr 6, 2020

ankitvaidya commented Apr 7, 2020

sashrith commented Apr 7, 2020

divyenpatel commented Apr 7, 2020

divyenpatel commented Apr 7, 2020 •

edited

Loading

divyenpatel commented Apr 7, 2020

r-shreesha commented Apr 7, 2020

r-shreesha commented Apr 7, 2020

xing-yang commented Apr 7, 2020

xing-yang commented Apr 7, 2020

SandeepPissay commented Apr 7, 2020

SandeepPissay commented Apr 7, 2020

alex1989hu Apr 7, 2020

divyenpatel Apr 7, 2020

nickvth Apr 8, 2020 •

edited

Loading

shawnho1018 Apr 11, 2020

nickvth Apr 12, 2020

shawnho1018 Apr 12, 2020 •

edited

Loading

alex1989hu Apr 7, 2020

alex1989hu Apr 7, 2020

alex1989hu Apr 7, 2020

alex1989hu Apr 7, 2020

alex1989hu Apr 8, 2020

nickvth commented Apr 10, 2020

vSphere CSI Driver 2.0 #151

vSphere CSI Driver 2.0 #151

Conversation

divyenpatel commented Apr 6, 2020 • edited Loading

k8s-ci-robot commented Apr 6, 2020

k8s-ci-robot commented Apr 6, 2020

ankitvaidya commented Apr 7, 2020

sashrith commented Apr 7, 2020

divyenpatel commented Apr 7, 2020

divyenpatel commented Apr 7, 2020 • edited Loading

divyenpatel commented Apr 7, 2020

r-shreesha commented Apr 7, 2020

r-shreesha commented Apr 7, 2020

xing-yang commented Apr 7, 2020

xing-yang commented Apr 7, 2020

SandeepPissay commented Apr 7, 2020

SandeepPissay commented Apr 7, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nickvth Apr 8, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shawnho1018 Apr 12, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nickvth commented Apr 10, 2020

divyenpatel commented Apr 6, 2020 •

edited

Loading

divyenpatel commented Apr 7, 2020 •

edited

Loading

nickvth Apr 8, 2020 •

edited

Loading

shawnho1018 Apr 12, 2020 •

edited

Loading