Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove mounting vsphere-config-secret in vsphere-csi-node daemonset #181

Conversation

divyenpatel
Copy link
Member

@divyenpatel divyenpatel commented Apr 16, 2020

What this PR does / why we need it:
This PR is removing mounting of vsphere-config-secret in vsphere-csi-node daemonset pods.

vsphere-config-secret is only required on node daemonset when topology feature is to be used.
This is required in the topology aware setup so that node can determine its topology by connecting to vCenter, to publish AccessibleTopology in the NodeGetInfoResponse.

Why we need this change now?
this change was already present in v1.0.2, but while merging development repository, this change was missed in this PR - #151

@RaunakShah added this fix in v1.0.2 - 136e3ec

Special notes for your reviewer:

Verified correctness in the yaml change with deploying driver using this updated yaml and latest image.

% kubectl create -f .
deployment.apps/vsphere-csi-controller created
csidriver.storage.k8s.io/csi.vsphere.vmware.com created
daemonset.apps/vsphere-csi-node created

Also verified basic provisioning workflow.

Release note:

removed mounting vsphere-config-secret requirement in vsphere-csi-node daemonset

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 16, 2020
@divyenpatel divyenpatel changed the title removed mounting vsphere-config-secret in vsphere-csi-node daemonset remove mounting vsphere-config-secret in vsphere-csi-node daemonset Apr 16, 2020
@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyenpatel, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [divyenpatel,xing-yang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3acd0e0 into kubernetes-sigs:master Apr 16, 2020
RaunakShah pushed a commit to RaunakShah/vsphere-csi-driver that referenced this pull request Jul 9, 2020
…ting-vsphere-secret-on-all-nodes

remove mounting vsphere-config-secret in vsphere-csi-node daemonset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants