Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with vsphere-csi-controller-deployment.yaml #157

Closed
mattrcampbell opened this issue Apr 9, 2020 · 4 comments
Closed

Issue with vsphere-csi-controller-deployment.yaml #157

mattrcampbell opened this issue Apr 9, 2020 · 4 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@mattrcampbell
Copy link

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind feature

What happened:

Deploying syncer with vsphere-csi-controller-deployment.yaml results in the following error:

"flag provided but not defined: -leader-election"

Using the image "gcr.io/cloud-provider-vsphere/csi/release/syncer:v1.0.2"

What you expected to happen:

Syncer would start normally.

How to reproduce it (as minimally and precisely as possible):

Kubectl apply -f vsphere-csi-controller-deployment.yaml

Anything else we need to know?:

Environment:

  • csi-vsphere version: v1.0.2
  • vsphere-cloud-controller-manager version: v1.1.0
  • Kubernetes version: 1.17.4
  • vSphere version: 6.7 u3
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 9, 2020
@divyenpatel
Copy link
Member

v1.0.2 does not have -leader-election support.

leader-election support is added in v2.0.0 as mentioned in the #151

If you are interested in trying out 2.0 driver, you can use following images generated for above pull request.

gcr.io/cloud-provider-vsphere/csi/ci/driver:v1.0.2-257-g51199e1
gcr.io/cloud-provider-vsphere/csi/ci/syncer:v1.0.2-257-g51199e1

Once 2.0 driver is released, we will update yamls.

@mattrcampbell
Copy link
Author

That makes sense. The old YAML files listed in the instructions went away, so you can no longer follow the directions at: https://github.com/kubernetes/cloud-provider-vsphere/raw/master/manifests/controller-manager/vsphere-cloud-controller-manager-ds.yaml
s

I went looking for files and these were the ones I found.

@divyenpatel
Copy link
Member

divyenpatel commented Apr 17, 2020

@mattrcampbell we will put back older yamls for v.1.0.2 driver with this PR - #179

cc: @SandeepPissay @manojvs157

@divyenpatel
Copy link
Member

fixed with #179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

3 participants