Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helm installation instructions #46

Closed
wants to merge 1 commit into from

Conversation

Yannig
Copy link

@Yannig Yannig commented Apr 19, 2021

Use kvaps/nfs-server-provisioner instead of stable/nfs-server-provisioner + instructions to add kvaps repository

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 19, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @Yannig!

It looks like this is your first PR to kubernetes-sigs/nfs-ganesha-server-and-external-provisioner 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/nfs-ganesha-server-and-external-provisioner has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Yannig
To complete the pull request process, please assign ashishranjan738 after the PR has been reviewed.
You can assign the PR to them by writing /assign @ashishranjan738 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from kmova and wongma7 April 19, 2021 12:30
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 19, 2021
@Yannig
Copy link
Author

Yannig commented Apr 19, 2021

CLA ok

@kvaps
Copy link
Member

kvaps commented Apr 19, 2021

@Yannig, first, thank you for contribution!

@kmova what do you think, if this a good idea to use my helm repository, or should we prepare the official one?

ref #25

@kmova
Copy link
Contributor

kmova commented Apr 27, 2021

@kvaps - it would be good if we can push the helm chart via github added to this repo.

Just got around to doing this with help of @yonatankahana.
https://github.com/kubernetes-sigs/nfs-subdir-external-provisioner

It is a few steps though.

@kvaps
Copy link
Member

kvaps commented Apr 27, 2021

I'm not big fan for storing binary files in git, but of course we can have separate branch. 😀
Thus we need a new clean gh-pages branch and some prow automation I guess?

@kvaps
Copy link
Member

kvaps commented Jul 13, 2021

@kmova could you please guide, what steps should be done to enable githab pages for this repo and host helm chart repository on it?

@kmova
Copy link
Contributor

kmova commented Aug 1, 2021

@kvaps -- these are the steps:

@k8s-ci-robot
Copy link
Contributor

@Yannig: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2021
@kvaps
Copy link
Member

kvaps commented Oct 6, 2021

closed in favor #65
thank you for contribution!

/close

@k8s-ci-robot
Copy link
Contributor

@kvaps: Closed this PR.

In response to this:

closed in favor #65
thank you for contribution!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants