Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github action to release helm charts #65

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

kvaps
Copy link
Member

@kvaps kvaps commented Aug 26, 2021

Add github action to create chart releases automatically once the chart version is bumped.
After this PR and creation of orphan branch named gh-pages - this repository could be used in helm repo add command.

helm repo add nfs-ganesha-server-and-external-provisioner https://kubernetes-sigs.github.io/nfs-ganesha-server-and-external-provisioner/

For example, my fork can be used:

$ helm repo add nfs-ganesha-server-and-external-provisioner https://kvaps.github.io/nfs-ganesha-server-and-external-provisioner/
"nfs-ganesha-server-and-external-provisioner" has been added to your repositories
$ helm search repo
NAME                                           	CHART VERSION	APP VERSION	DESCRIPTION                                       
nfs-ganesha-server-and-external-provisioner/nfs...	1.3.2             	3.0.0             	nfs-server-provisioner is an out-of-tree dynami...

To create the gh-pages branch use: git checkout --orphan gh-pages.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 26, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 26, 2021
@@ -29,7 +29,8 @@ package manager.
To install the chart with the release name `my-release`:

```console
$ helm install stable/nfs-server-provisioner --name my-release
$ helm repo add nfs-ganesha-server-and-external-provisioner https://kubernetes-sigs.github.io/nfs-ganesha-server-and-external-provisioner/
Copy link
Contributor

@consideRatio consideRatio Aug 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps helm repo update required here also?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've stopped doing this and rely on --repo flags when doing helm install or helm upgrade so I've forgotten.

Copy link
Contributor

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides a documentation comment, this LGTM!

@kmova
Copy link
Contributor

kmova commented Sep 4, 2021

@kvaps - the gh-pages branch is pushed. I am good with this PR. Would you like me to go ahead or wait for resolving the minor doc comment.

@kmova
Copy link
Contributor

kmova commented Sep 30, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: consideRatio, kmova, kvaps

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fec7159 into kubernetes-sigs:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants