-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github action to release helm charts #65
Conversation
@@ -29,7 +29,8 @@ package manager. | |||
To install the chart with the release name `my-release`: | |||
|
|||
```console | |||
$ helm install stable/nfs-server-provisioner --name my-release | |||
$ helm repo add nfs-ganesha-server-and-external-provisioner https://kubernetes-sigs.github.io/nfs-ganesha-server-and-external-provisioner/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps helm repo update
required here also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've stopped doing this and rely on --repo
flags when doing helm install
or helm upgrade
so I've forgotten.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides a documentation comment, this LGTM!
@kvaps - the |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: consideRatio, kmova, kvaps The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add github action to create chart releases automatically once the chart version is bumped.
After this PR and creation of orphan branch named
gh-pages
- this repository could be used inhelm repo add
command.For example, my fork can be used:
To create the
gh-pages
branch use:git checkout --orphan gh-pages
.