Add github action to release helm charts

[yonatankahana]

Add github action to create chart releases automatically once the chart version is bumped.
After this PR and creation of orphan branch named gh-pages - this repository could be used in helm repo add command.

helm repo add nfs-subdir-external-provisioner https://kubernetes-sigs.github.io/nfs-subdir-external-provisioner/

For example, my fork can be used:

$ helm repo add nfs-subdir-external-provisioner https://yonatankahana.github.io/nfs-subdir-external-provisioner/
"nfs-subdir-external-provisioner" has been added to your repositories
$ helm search repo
NAME                                           	CHART VERSION	APP VERSION	DESCRIPTION                                       
nfs-subdir-external-provisioner/nfs-subdir-external-provisioner	4.0.0        	3.1.0      	nfs-subdir-external-provisioner is an automatic...

To create the gh-pages branch use: git checkout --orphan gh-pages.

[wongma7]

I'm not sure if I have permission to create a new branch, will try.

Also will need make sure the gh-pages branch gets marked unprotected so that the action has permission to write to it (obviously github action cannot sign a cla):

https://github.com/kubernetes/test-infra/pull/20323/files

[wongma7]

this part unnecessary, chart releaser action should be enough like at https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/.github/workflows/helm-chart-release.yaml#L22

[yonatankahana]

excellent, i deleted that.

[yonatankahana]

Also will need make sure the gh-pages branch gets marked unprotected so that the action has permission to write to it (obviously github action cannot sign a cla)

follow: kubernetes/test-infra#20453

[kmova]

Was able to push in the gh-pages branch. @yonatankahana @wongma7 - please check if you would like to modify/update the default index.md with any further information.

[yonatankahana]

please check if you would like to modify/update the default index.md with any further information.

i have left 2 cosmetics comments and 1 important comment about the readme location.

edit:
also solved the merged conflict since #39 merged.

[kmova]

@yonatankahana - just wondering if we should keep the charts in the following location => deploy/helm/charts, to have all the different ways of deployments in the deploy folder.

The chart release can be configured with a custom directory as follows: https://github.com/openebs/node-disk-manager/blob/master/.github/workflows/release-charts.yml#L33

[yonatankahana]

@yonatankahana - just wondering if we should keep the charts in the following location => deploy/helm/charts, to have all the different ways of deployments in the deploy folder.

The chart release can be configured with a custom directory as follows: https://github.com/openebs/node-disk-manager/blob/master/.github/workflows/release-charts.yml#L33

I always prefer to stick with as many defaults as possible, it leads to conventions. If everyone uses the default it will be easier for the user to find what they are looking for because it will be the same in every (git as helm) repositories.
In a short search I did in other repositories I see that there is a lack of convention and everyone places the chart in a different place so that in any case - there is no real convention other than this default.
(One way or another - the deploy/ folder with the deploy/objects/ feels a bit like duplication.)

tl;dr
I'll go with the default: charts/.

[kmova]

@yonatankahana, I agree with:

stick with as many defaults as possible

[kmova]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kmova, yonatankahana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kmova]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment