Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crio runc path on Ubuntu #6035

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Fix crio runc path on Ubuntu #6035

merged 1 commit into from
Apr 28, 2020

Conversation

Miouge1
Copy link
Contributor

@Miouge1 Miouge1 commented Apr 28, 2020 •
edited
Loading

What type of PR is this?
/kind bug
/kind failing-test

What this PR does / why we need it:
Tests failed with:

Apr 28 00:20:56 kubespray-crio-ubuntu crio[5383]: time="2020-04-28 00:20:56.476564397-07:00" level=fatal msg="runtime config: runtime validation: invalid runtime_path for runtime 'runc': \"stat /usr/lib/cri-o-runc/sbin/runc: no such file or directory\""

Also changing the platform names to be shorter and easier to use and including some doc about molecule login

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 28, 2020
@Miouge1 Miouge1 added this to the 2.13 milestone Apr 28, 2020
@Miouge1
Copy link
Contributor Author

Miouge1 commented Apr 28, 2020

I'll close and reopen to refresh CI?

@Miouge1 Miouge1 closed this Apr 28, 2020
@Miouge1 Miouge1 reopened this Apr 28, 2020
This was referenced Apr 28, 2020
Merged
Merged
@Miouge1 Miouge1 force-pushed the fix-crio-svc-ubunt branch from 611deba to b15d6ed Compare April 28, 2020 09:38
@floryut
Copy link
Member

floryut commented Apr 28, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit 28333d4 into kubernetes-sigs:master Apr 28, 2020
This was referenced Apr 28, 2020
Closed
Merged
Merged
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request May 29, 2020
@Miouge1 @LuckySB
Fix crio runc path on Ubuntu (kubernetes-sigs#6035)
af849f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut Awaiting requested review from floryut

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
2.13
Development

Successfully merging this pull request may close these issues.
3 participants
@Miouge1 @k8s-ci-robot @floryut