ADD tls cipher suites support

[liupeng0518]

What type of PR is this?
/kind feature

What this PR does / why we need it:
Sometimes for security reasons, We need to add tls cipher suites and tls min version.
Which issue(s) this PR fixes:

add tls cipher suites

add tls min version

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

# tls min version: Possible values: VersionTLS10, VersionTLS11, VersionTLS12, VersionTLS13
# tls_min_version: ""

# tls cipher suites
# tls_cipher_suites: {}
# - TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA
# - TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256
# - TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256
# - TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA
# - TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384
# - TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305
# - TLS_ECDHE_ECDSA_WITH_RC4_128_SHA
# - TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA
# - TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA
# - TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256
# - TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
# - TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA
# - TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
# - TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305
# - TLS_ECDHE_RSA_WITH_RC4_128_SHA
# - TLS_RSA_WITH_3DES_EDE_CBC_SHA
# - TLS_RSA_WITH_AES_128_CBC_SHA
# - TLS_RSA_WITH_AES_128_CBC_SHA256
# - TLS_RSA_WITH_AES_128_GCM_SHA256
# - TLS_RSA_WITH_AES_256_CBC_SHA
# - TLS_RSA_WITH_AES_256_GCM_SHA384
# - TLS_RSA_WITH_RC4_128_SHA

[k8s-ci-robot]

Hi @liupeng0518. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[woopstar]

As we are a production-ready cluster, we should default these settings to secure values. At least for TLS 1.2

[Miouge1]

@woopstar from what I see in the current PR, if undefined (which it is by default) it uses whatever kubeadm says, hopefully that's a secure default?

@liupeng0518 you need to fix a couple of yaml issues:

$ yamllint --strict .
 ./inventory/sample/group_vars/k8s-cluster/k8s-cluster.yml
   264:1     warning  comment not indented like content  (comments-indentation)
 ./roles/kubernetes/master/defaults/main/main.yml
   170:1     warning  comment not indented like content  (comments-indentation)

[floryut]

Tls 1.2 by default

func DefaultTLSVersion() uint16 {
	// Can't use SSLv3 because of POODLE and BEAST
	// Can't use TLSv1.0 because of POODLE and BEAST using CBC cipher
	// Can't use TLSv1.1 because of RC4 cipher usage
	return tls.VersionTLS12
}

[woopstar]

Then it's ok with me :)

[liupeng0518]

@woopstar from what I see in the current PR, if undefined (which it is by default) it uses whatever kubeadm says, hopefully that's a secure default?

@liupeng0518 you need to fix a couple of yaml issues:

$ yamllint --strict .
 ./inventory/sample/group_vars/k8s-cluster/k8s-cluster.yml
   264:1     warning  comment not indented like content  (comments-indentation)
 ./roles/kubernetes/master/defaults/main/main.yml
   170:1     warning  comment not indented like content  (comments-indentation)

OK. Fix it.

[Miouge1]

The crio error in CI is unrelated to this PR. It will be fixed in #6035 so you will need to rebase once #6035 is merged.

[floryut]

The crio error in CI is unrelated to this PR. It will be fixed in #6035 so you will need to rebase once #6035 is merged.

@liupeng0518 and it's merge, please rebase :)

[Miouge1]

/ok-to-test

[woopstar]

Since both tls_min_version and tls_cipher_suites is never set in any vars for any test, our CI will never test if this actually works.

[liupeng0518]

Since both tls_min_version and tls_cipher_suites is never set in any vars for any test, our CI will never test if this actually works.

set default values

[Miouge1]

I think the previous way was better, and could have been tested with adding the option in one of the tests/files/*.yml

[floryut]

@liupeng0518 Can you please rebase ?
Also can you see latest comments, the idea is not to add a default for everyone but only to change one of the test file to ensure everything is OK

[k8s-ci-robot]

@liupeng0518: The following commands are available to trigger jobs:

• /test pull-kubespray-yamllint

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[liupeng0518]

@floryut done.

[Miouge1]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liupeng0518, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Miouge1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Miouge1]

The existing addons CI job would be better suited, we don't have to add a new CI job for every flag

[liupeng0518]

@Miouge1 packet_centos7-flannel-containerd-addons-ha is ok?

[floryut]

@Miouge1 packet_centos7-flannel-containerd-addons-ha is ok?

Yup that would do

[Miouge1]

Yep! ❤️

[liupeng0518]

@Miouge1 @floryut done.

[floryut]

/lgtm