Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow dns-autoscaler requests to be specified via variables #6020

Merged

Conversation

0x4c6565
Copy link
Contributor

@0x4c6565 0x4c6565 commented Apr 24, 2020

What type of PR is this?
/kind feature

What this PR does / why we need it:

Allow the memory/cpu requests to be specified via variables dns_autoscaler_cpu_requests and dns_autoscaler_memory_requests

Which issue(s) this PR fixes:

Fixes #6019

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 24, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @0x4c6565!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @0x4c6565. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from bozzo and floryut April 24, 2020 13:55
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 24, 2020
@floryut
Copy link
Member

floryut commented Apr 24, 2020

Thanks @0x4c6565
Can you sign CLA ?

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 24, 2020
@floryut
Copy link
Member

floryut commented Apr 27, 2020

@0x4c6565 Thank you, don't forget to sign CLA; otherwise all good.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2020
@0x4c6565 0x4c6565 force-pushed the dns-autoscaler-limit-variables branch from 9cbc096 to 0797c0b Compare April 27, 2020 10:41
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2020
@0x4c6565
Copy link
Contributor Author

I've signed the CLA (work email address is attached to my Github account), however CI is failing :(

@floryut
Copy link
Member

floryut commented Apr 27, 2020

/retest

1 similar comment
@0x4c6565
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 27, 2020
@0x4c6565
Copy link
Contributor Author

CLA sorted :)

@floryut
Copy link
Member

floryut commented Apr 28, 2020

CLA sorted :)

Great, sorry about that but could you rebase ? #6035 is merged and should fix the molecule job error on your PR

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 28, 2020
@0x4c6565
Copy link
Contributor Author

CLA sorted :)

Great, sorry about that but could you rebase ? #6035 is merged and should fix the molecule job error on your PR

Done

@floryut
Copy link
Member

floryut commented Apr 28, 2020

CLA sorted :)

Great, sorry about that but could you rebase ? #6035 is merged and should fix the molecule job error on your PR

Done

Please recheck your git history looks like you are now shipping commits that shouldn't be there

@0x4c6565 0x4c6565 force-pushed the dns-autoscaler-limit-variables branch from d533a4b to 6175ba6 Compare April 28, 2020 13:41
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 28, 2020
@floryut
Copy link
Member

floryut commented Apr 28, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Apr 29, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0x4c6565, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit a3d3f27 into kubernetes-sigs:master Apr 29, 2020
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow memory requests to be set for dns-autoscaler deployment
4 participants