-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow dns-autoscaler requests to be specified via variables #6020
allow dns-autoscaler requests to be specified via variables #6020
Conversation
Welcome @0x4c6565! |
Hi @0x4c6565. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Thanks @0x4c6565 /ok-to-test |
9cbc096
to
0797c0b
Compare
I've signed the CLA (work email address is attached to my Github account), however CI is failing :( |
/retest |
1 similar comment
/retest |
CLA sorted :) |
Great, sorry about that but could you rebase ? #6035 is merged and should fix the molecule job error on your PR |
Done |
Please recheck your git history looks like you are now shipping commits that shouldn't be there |
d533a4b
to
6175ba6
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0x4c6565, Miouge1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Allow the memory/cpu requests to be specified via variables
dns_autoscaler_cpu_requests
anddns_autoscaler_memory_requests
Which issue(s) this PR fixes:
Fixes #6019
Special notes for your reviewer:
Does this PR introduce a user-facing change?: