-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Initial Conformance Test Framework #20
Comments
is this not related https://github.com/kubernetes-sigs/ingress-controller-conformance? if affirmative, should we merge it into this repo? |
@aojea It is related, but unfortunately it doesn't follow the pattern established by the Kubernetes conformance tests. @aledbf has some work in progress for ingress conformance following that pattern, I'd been thinking about using that as a starting point for work here as well. |
The current conformance suite was proposed and accepted on the mailing list https://groups.google.com/d/msg/kubernetes-sig-network/dAt78O-JUCo/vvOXt3-XCgAJ Conformance testing needs to test not just the v2 API, but also Ingress v1beta1 and v1. I am not sure that it should live in this repo, since it has a broader scope. I would prefer to avoid building 2 separate suites and ending up with different overlapping tests. Probably @aledbf and @alexgervais should discuss? |
When https://github.com/kubernetes-sigs/ingress-controller-conformance started, it was intended to support It is desirable to have a single conformance test suite for @aledbf , thoughts? |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
/remove-lifecycle stale |
…xample Add e2e example for gRPC LB
I think this issue was resolved by #969 |
Woops, thanks @markmc! /close |
@robscott: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We want to ensure that controllers using these APIs are conformant. Having a good conformance test suite will help establish consistency across community implementations and help developers identify any missing pieces in their implementation. This should work similarly to the existing Kubernetes conformance tests and be accessible with the same workflows.
The text was updated successfully, but these errors were encountered: