Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Initial Conformance Test Framework #20

Closed
robscott opened this issue Jan 8, 2020 · 13 comments
Closed

Add Initial Conformance Test Framework #20

robscott opened this issue Jan 8, 2020 · 13 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@robscott
Copy link
Member

robscott commented Jan 8, 2020

We want to ensure that controllers using these APIs are conformant. Having a good conformance test suite will help establish consistency across community implementations and help developers identify any missing pieces in their implementation. This should work similarly to the existing Kubernetes conformance tests and be accessible with the same workflows.

@aojea
Copy link
Contributor

aojea commented Jan 15, 2020

is this not related https://github.com/kubernetes-sigs/ingress-controller-conformance?

if affirmative, should we merge it into this repo?

@robscott
Copy link
Member Author

@aojea It is related, but unfortunately it doesn't follow the pattern established by the Kubernetes conformance tests. @aledbf has some work in progress for ingress conformance following that pattern, I'd been thinking about using that as a starting point for work here as well.

@bowei bowei added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Feb 6, 2020
@jpeach
Copy link
Contributor

jpeach commented Feb 7, 2020

The current conformance suite was proposed and accepted on the mailing list

https://groups.google.com/d/msg/kubernetes-sig-network/dAt78O-JUCo/vvOXt3-XCgAJ
kubernetes/org#1328

Conformance testing needs to test not just the v2 API, but also Ingress v1beta1 and v1. I am not sure that it should live in this repo, since it has a broader scope. I would prefer to avoid building 2 separate suites and ending up with different overlapping tests.

Probably @aledbf and @alexgervais should discuss?

@alexgervais
Copy link

alexgervais commented Feb 7, 2020

When https://github.com/kubernetes-sigs/ingress-controller-conformance started, it was intended to support v1beta1 and v1 Ingress APIs for various ingress-controller implementations outside the core k/k.

It is desirable to have a single conformance test suite for v1beta1, v1 Ingress and v2 Service APIs. We have not committed to using the sonobuoy in kubernetes-sigs/ingress-controller-conformance, but building on a common ground would make total sense. The worst possible thing would be to completely diverge on approaches here and have the 2 suites diverge so early in their inception.

@aledbf , thoughts?

@jpeach
Copy link
Contributor

jpeach commented Feb 15, 2020

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 16, 2020
@bowei bowei removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 19, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 17, 2020
@jpeach
Copy link
Contributor

jpeach commented Aug 19, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 19, 2020
@robscott robscott added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 11, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 9, 2021
@robscott
Copy link
Member Author

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 10, 2021
@jpeach jpeach mentioned this issue Jul 26, 2021
jaison-tiu pushed a commit to jaison-tiu/gateway-api that referenced this issue Apr 14, 2022
@markmc
Copy link
Contributor

markmc commented May 31, 2022

I think this issue was resolved by #969

@robscott
Copy link
Member Author

Woops, thanks @markmc!

/close

@k8s-ci-robot
Copy link
Contributor

@robscott: Closing this issue.

In response to this:

Woops, thanks @markmc!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
8 participants