Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create container image repository for built images #3

Closed
bowei opened this issue Dec 13, 2019 · 20 comments
Closed

Create container image repository for built images #3

bowei opened this issue Dec 13, 2019 · 20 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@bowei
Copy link
Contributor

bowei commented Dec 13, 2019

We will need a gcr.io docker image repo for the built artifacts:

https://github.com/kubernetes/k8s.io/blob/master/k8s.gcr.io/README.md
https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/README.md
@bowei bowei added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Dec 13, 2019
@aojea aojea mentioned this issue Dec 16, 2019
Merged
@aojea
Copy link
Contributor

aojea commented Dec 16, 2019

/assign
xref: kubernetes/k8s.io#515

@thockin
Copy link

thockin commented Dec 17, 2019

I am curious what artifacts you expect to build and publish?

@youngnick youngnick mentioned this issue Jan 9, 2020
Merged
@aojea aojea mentioned this issue Jan 9, 2020
Merged
@aojea
Copy link
Contributor

aojea commented Jan 13, 2020

@bowei only is missing the cloudbuild.yaml

https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/README.md#cloudbuildyaml

and defining the artifacts #3 (comment)

@bowei
Copy link
Contributor Author

bowei commented Jan 13, 2020

@thockin -- conformance test suite and there are some build related images would be helpful to keep a golden image to get repeat ability.

@alexgervais
Copy link

@aojea do you know if it's possible to share a gcr.io container repo between projects? We'd like to piggyback on the work done here for the ingress-conformance images
ref. kubernetes-sigs/ingress-controller-conformance#27

@aojea
Copy link
Contributor

aojea commented Feb 6, 2020

@alexgervais do you think that is possible to use one of the kubernetes/kubernetes images used for testing?

I think that the agnhost image has the same functionality

https://github.com/kubernetes/kubernetes/tree/master/test/images/agnhost#netexec

and it's maintained by the project and published to a public registry

gcr.io/kubernetes-e2e-test-images/agnhost

@jpeach
Copy link
Contributor

jpeach commented Feb 7, 2020

xref conformance test suite discussion in #20

@alexgervais
Copy link

@aojea agnhost is a very interesting project. However, it does not fit our requirements as the netexec server does not allow dumping the original request in the server's response, and injecting environment variables -- allowing us to later assert upon this data set. Also, since the behaviour of netexec is dictated by HTTP endpoints, it would not allow us to test the routing behaviour on matched and unmatched Exact or Prefix path types as all routes would be required to re-write the original request to /hostname for example.

We could of course upstream the ./tools/echoserver.go binary cmd into agnhost but I think keeping this binary and docker image closer to the ingress-conformance test suite would allow us to iterate faster.

I would also wish to publish the ingress-controller-conformance binary as a docker image for folks who would like to run the suite as part of their CI.

@aojea
Copy link
Contributor

aojea commented Feb 7, 2020

honestly don't know how this image publishing process works, we should ask sig-testing if it's possible to publish artifacts from different repos to one bucket, but doesn't seem a good solution because of the complexity of maintaining it in the long term.

Maybe you can ask for a new bucket to publish images in https://github.com/kubernetes-sigs/ingress-controller-conformance?

We will need a gcr.io docker image repo for the built artifacts:

https://github.com/kubernetes/k8s.io/blob/master/k8s.gcr.io/README.md
https://github.com/kubernetes/test-infra/blob/master/config/jobs/image-pushing/README.md

@youngnick
Copy link
Contributor

So, to follow up here, there are currently two container artifacts referenced in this repo:

  • k8s.gcr.io/service-apis-mkdocs:latest, this is used for all docs-related tasks and is currently built from scratch each build. Making this available globally would be useful.
  • controller:latest - this is able to be created when testing the API types using the kubebuilder code. I don't think it's used anywhere yet, since the types are not functional. Obviously, it could not be made available currently because it's not namespaced.

I think the repo for the first is a guess, and is not set in stone if it needs to be pushed somewhere else. Right now, it does nothing as the result is not pushed anywhere, and there is no push functionality in docs.mk.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 13, 2020
@bowei bowei removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 19, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 17, 2020
@aojea aojea removed their assignment Sep 9, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 9, 2020
@youngnick
Copy link
Contributor

/remove-lifecycle stale
/remove-lifecycle rotten

I think the only utility here is to make the builds/testing a bit faster by allowing reuse of the mkdocs container. Given the amount of time this has lain dormant, we can probably just close it out. Thoughts?

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 29, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 27, 2021
@hbagdi
Copy link
Contributor

hbagdi commented Feb 11, 2021

I think this issue now becomes important again with @cmluciano's work on validating webhook, which requires a container repository (#487).
@bowei @robscott Do you have any guidance on how to go about doing this?

@aojea
Copy link
Contributor

aojea commented Feb 11, 2021

The container repository was created, it is missing to configure the repo to automate the build
#3 (comment)

@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 13, 2021
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mark-church mark-church mentioned this issue Apr 13, 2021
Closed
jaison-tiu pushed a commit to jaison-tiu/gateway-api that referenced this issue Apr 14, 2022
@mark-church
Merge pull request kubernetes-sigs#3 from GoogleCloudPlatform/add-gat…
d4d9b97 
…eway-tutorial

Removed extra route from multi-cluster example
@candita candita mentioned this issue Jun 12, 2023
Open
@dprotaso dprotaso mentioned this issue Jun 19, 2023
Merged
candita added a commit to candita/gateway-api that referenced this issue Jul 18, 2023
@candita
GEP-1897 Update with API details - suggested changes kubernetes-sigs#3
a2b2dbc
k8s-ci-robot pushed a commit that referenced this issue Sep 6, 2023
@candita @robscott
GEP-1897 Explicit Backend TLS Connection Configuration (was TLS from …
d09b142 
…Gateway to Backend...) Update with API details (#2113)

* GEP-1897 Update with API details

* GEP-1897 Update with API details - suggested changes #1

* Update geps/gep-1897.md

Co-authored-by: Rob Scott <rob.scott87@gmail.com>

* Update geps/gep-1897.md

Co-authored-by: Rob Scott <rob.scott87@gmail.com>

* GEP-1897 Update with API details - suggested changes #2

* GEP-1897 Update with API details - suggested changes #3

* GEP-1897 Update with API details - suggested changes 4

* GEP-1897 Update with API details - suggested changes 5

* GEP-1897 Update with API details - suggested changes 7

* GEP-1897 Update with API details - suggested changes 8

* GEP-1897 Update with API details - suggested changes 9

* GEP-1897 Update with API details - suggested changes 10

* GEP-1897 Update with API details - suggested changes 11

---------

Co-authored-by: Rob Scott <rob.scott87@gmail.com>
@kflynn kflynn mentioned this issue Apr 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@jpeach @alexgervais @bowei @hbagdi @thockin @aojea @youngnick @k8s-ci-robot @fejta-bot