Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API Tests #520

Closed
danehans opened this issue Jan 6, 2021 · 4 comments
Closed

Add API Tests #520

danehans opened this issue Jan 6, 2021 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@danehans
Copy link
Contributor

danehans commented Jan 6, 2021

What would you like to be added:
API tests.

Why is this needed:
The current tests only ensure the CRDs and examples can be installed to a cluster. Tests are needed that compare the current and expected values of API types. For example, many API fields are being defaulted but no tests exist to ensure the defaults are being properly set.

/cc @robscott @hbagdi

xref: #517
@danehans danehans added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 6, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 6, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 6, 2021
@jpeach
Copy link
Contributor

jpeach commented Jul 26, 2021

xref #691

@jpeach
Copy link
Contributor

jpeach commented Jul 26, 2021

Duplicate of #20

@jpeach jpeach marked this as a duplicate of #20 Jul 26, 2021
@jpeach jpeach closed this as completed Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jpeach @danehans @k8s-ci-robot @fejta-bot