Skip to content

The TLS Mode Field is not Being Defaulted #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danehans opened this issue Jan 6, 2021 · 1 comment · Fixed by #518
Closed

The TLS Mode Field is not Being Defaulted #517

danehans opened this issue Jan 6, 2021 · 1 comment · Fixed by #518
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@danehans
Copy link
Contributor

danehans commented Jan 6, 2021

What happened:
The gateway.spec.tls.mode field is not being defaulted.

What you expected to happen:
The field set to "Terminate" (i.e. the default) when unspecified.

How to reproduce it (as minimally and precisely as possible):

  • cat examples/wildcard-https.yaml
  • make install
  • kubectl get gateways/gateway -o yaml

Anything else we need to know?:
Other fields that should be defaulted may be effected by this bug.

@danehans danehans added the kind/bug Categorizes issue or PR as related to a bug. label Jan 6, 2021
@danehans
Copy link
Contributor Author

danehans commented Jan 6, 2021

The TLS mode is unspecified:

$ cat examples/wildcard-https.yaml 
kind: Gateway
...
    tls:
      options: {}
      certificateRef:
        name: example-wildcard
        kind: Secret
        group: core
    ...

The mode should be set to "Terminate" (default) but it's nil:

$ kubectl get gateways/gateway -o yaml
apiVersion: networking.x-k8s.io/v1alpha1
kind: Gateway
...
    tls:
      certificateRef:
        group: core
        kind: Secret
        name: example-wildcard
      options: {}
      routeOverride:
        certificate: Deny
...

This was referenced Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant