Tests: Add unit test and run tests with root privileges

[animeshk08]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind test
What this PR does / why we need it:
Improves test coverage
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
The unit test now requires root privileges to run.
This is necessary as some operation like mounting need root priviledge

Release note:

Tests: Add unit tests for node server
Tests: Run unit tests with root priviledges
Tests: Add tests for node server

[k8s-ci-robot]

Hi @animeshk08. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[animeshk08]

Partially fixes the issue: #258

[andyzhangx]

/ok-to-test

[andyzhangx]

@chewong some unit tests needs root permission, do you know where should we put sudo, should it be in test-infra repo, this PR tried sudo go test -v ..., it failed. thanks.

Activated service account credentials for: [pr-kubekins@kubernetes-jenkins-pull.iam.gserviceaccount.com]
+ make verify
sudo go test -v -race ./pkg/... ./test/utils/credentials
make: sudo: Command not found
make: *** [Makefile:54: unit-test] Error 127
+ EXIT_VALUE=2
+ set +o xtrace

[chewong]

@chewong some unit tests needs root permission, do you know where should we put sudo, should it be in test-infra repo, this PR tried sudo go test -v ..., it failed. thanks.

Activated service account credentials for: [pr-kubekins@kubernetes-jenkins-pull.iam.gserviceaccount.com]
+ make verify
sudo go test -v -race ./pkg/... ./test/utils/credentials
make: sudo: Command not found
make: *** [Makefile:54: unit-test] Error 127
+ EXIT_VALUE=2
+ set +o xtrace

Opened kubernetes/test-infra#17685, which might fix the issue. I don't think sudo is available in the test container. Could you try removing it?

[andyzhangx]

/test pull-azurefile-csi-driver-verify
/test pull-azurefile-csi-driver-unit

[andyzhangx]

@animeshk08 could you remove sudo, and try again? thanks.

[animeshk08]

Thanks @andyzhangx make works now. Let me fix the errors then we are good to go with this PR :)

[andyzhangx]

@animeshk08 can you squash commits next time, e.g.

git rebase -i HEAD~5

[andyzhangx]

/test pull-azurefile-csi-driver-verify

[andyzhangx]

the error is different now:

=== RUN   TestNodePublishVolume
E0523 23:59:13.572690    8852 nodeserver.go:302] MakeDir failed on target: ./azure.go (mkdir ./azure.go: not a directory)
--- FAIL: TestNodePublishVolume (0.05s)
    nodeserver_test.go:147: 
        	Error Trace:	nodeserver_test.go:147
        	Error:      	Received unexpected error:
        	            	invalid argument
        	Test:       	TestNodePublishVolume
=== RUN   TestNodeUnpublishVolume
E0523 23:59:13.612379    8852 mount_linux.go:150] Mount failed: exit status 32

[animeshk08]

Thank you for the help @andyzhangx. The build is passing now 🚀 I have updated Github actions to run with sudo as well.

The new coverage is:
Coverage increased (+12.4%) to 48.826%

[andyzhangx]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, animeshk08

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [andyzhangx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment