Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure: grant privileged context to azure file unit test #17685

Merged
merged 1 commit into from
May 22, 2020
Merged

Azure: grant privileged context to azure file unit test #17685

merged 1 commit into from
May 22, 2020
+5 −0

Conversation

chewong
Copy link
Member

@chewong chewong commented May 22, 2020

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels May 22, 2020
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label May 22, 2020
@chewong chewong mentioned this pull request May 22, 2020
Merged
andyzhangx
andyzhangx approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, chewong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7ab687f into kubernetes:master May 22, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 22, 2020
@k8s-ci-robot
Copy link
Contributor

@chewong: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key azurefile-csi-driver-config.yaml using file config/jobs/kubernetes-sigs/azurefile-csi-driver/azurefile-csi-driver-config.yaml
  • key release-1.16.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-1.16.yaml
  • key release-1.17.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-1.17.yaml
  • key release-1.18.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-1.18.yaml

In response to this:

Addressing kubernetes-sigs/azurefile-csi-driver#288 (comment).

Also following up with https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/636/files

/assign @andyzhangx

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chewong chewong deleted the patch-azure-file-unit-test branch May 22, 2020 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
3 participants
@chewong @k8s-ci-robot @andyzhangx