improve unit test coverage

[andyzhangx]

Is your feature request related to a problem?/Why is this needed

Describe the solution you'd like in detail

improve UT coverage including

• controllerserver
• nodeserver
• identityserver
• version

https://coveralls.io/github/kubernetes-sigs/azurefile-csi-driver?branch=master

Describe alternatives you've considered

Additional context

[Dhiraj240]

@andyzhangx Would like to work on it.

[andyzhangx]

@andyzhangx Would like to work on it.

thanks, this is a big part, just update which part your are working on this issue when you have any progress.

[andyzhangx]

and there are some easy parts, e.g. version.go, this issue is to improve the test code coverage, current ratio is awful, thanks.

[andyzhangx]

cc @kushthedude to take a look, thanks

[animeshk08]

Working on unit tests for https://github.com/kubernetes-sigs/azurefile-csi-driver/blob/master/pkg/azurefile/nodeserver.go. Mentioning to avoid redundant work :)

[animeshk08]

Update:

Uncovered files:

• server.go: Need to find a way to mock grpc requests.

Improve coverage:

• controllerserver.go: Need to create mock file client.
• nodeserver.go: Mock mount/unmount operation to remove the need of running the tests with root privileges.

[andyzhangx]

thanks @animeshk08 really impressive work!
Can you improve code coverage on csi-common? thanks

Current code coverage:

cc @Sakuralbj

[animeshk08]

Sure!
controllerserver-default.go has unimplemented methods which I have omitted. Hence the low coverage for that file.
I will start work on server.go.

[andyzhangx]

it's now 80%!

[andyzhangx]

it's now 85%, thanks for the contribution! @animeshk08 now close this issue.