Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v1.6] Fix broken CI #2953

Merged
merged 1 commit into from
Nov 7, 2023
Merged

[release/v1.6] Fix broken CI #2953

merged 1 commit into from
Nov 7, 2023

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Nov 7, 2023

What this PR does / why we need it:

Manual cherry-pick of #2934 to the release/v1.6 branch to fix jobs failing to start.

What type of PR is this?

/kind cleanup

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

/assign @kron4eg

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii requested a review from kron4eg November 7, 2023 12:50
@kubermatic-bot kubermatic-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 7, 2023
@kron4eg
Copy link
Member

kron4eg commented Nov 7, 2023

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 28e8c6ca4aa8a294745b43d76b795b928a736d76

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2023
@xmudrii
Copy link
Member Author

xmudrii commented Nov 7, 2023

/retest

@xmudrii
Copy link
Member Author

xmudrii commented Nov 7, 2023

/test pull-kubeone-e2e-aws-default-install-containerd-v1.26.1

@xmudrii
Copy link
Member Author

xmudrii commented Nov 7, 2023

The failing test will be fixed by #2958, I'm going to override the failing job so that we can unblock CI on this branch
/override pull-kubeone-e2e-aws-default-install-containerd-v1.26.1

@kubermatic-bot
Copy link
Contributor

@xmudrii: Overrode contexts on behalf of xmudrii: pull-kubeone-e2e-aws-default-install-containerd-v1.26.1

In response to this:

The failing test will be fixed by #2958, I'm going to override the failing job so that we can unblock CI on this branch
/override pull-kubeone-e2e-aws-default-install-containerd-v1.26.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii xmudrii added the cherry-pick-approved Indicates a PR has been approved by release managers. label Nov 7, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Nov 7, 2023
@kubermatic-bot kubermatic-bot merged commit a3ad409 into release/v1.6 Nov 7, 2023
13 checks passed
@kubermatic-bot kubermatic-bot deleted the fix-ci-1.6 branch November 7, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a PR has been approved by release managers. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants