-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix globbing for apt-get install #2958
Conversation
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
/cherrypick release/v1.7 |
@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release/v1.6 |
@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
LGTM label has been added. Git tree hash: a7a45a92376ee47e9dc145d5bb440604d3c21053
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@xmudrii: new pull request created: #2959 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@xmudrii: new pull request created: #2960 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
We have issue with globbing in
apt-get
install commands used to install Kubernetes. It can happen that1.x.1*
resolves to1.x.10-1.1
instead of1.x.1-1.1
This is fixed by changing the version passed to
apt-get
command to include-
after version, so the glob only matches the revision part and not the version part.This problem should only affect users trying to install
1.x.1
after1.x.10
has been released.What type of PR is this?
/kind bug
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation:
/assign @kron4eg