Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken CI #2934

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Fix broken CI #2934

merged 1 commit into from
Oct 20, 2023

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Oct 20, 2023

What this PR does / why we need it:
After our recent upgrade for prow https://github.com/kubermatic/infra/pull/2461, prow is no longer able to resolve symlinks for the job configurations.

{"branch":"main","component":"tide","controller":"status-update","error":"failed to set up context register: failed to get presubmits: failed to read contents of directory \".prow\": open /var/tmp/gitrepo90238935/.prow/generated.yaml: no such file or directory","file":"[k8s.io/test-infra/prow/tide/status.go:436](http://k8s.io/test-infra/prow/tide/status.go:436)","func":"[k8s.io/test-infra/prow/tide.(*statusController).setStatuses.func1](http://k8s.io/test-infra/prow/tide.(*statusController).setStatuses.func1)","level":"error","msg":"getting expected status","org":"kubermatic","pr":2933,"repo":"kubeone","severity":"error","sha":"798b13eb44ed826c8fdb1946863febd9a591327a","time":"2023-10-20T09:11:05Z"}

Thanks to @xrstf we found that kubernetes/test-infra#30400 was the change that broke this. Removing the symlink in favor of copying the file(generated via code) fixes the issue.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind chore

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 20, 2023
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Oct 20, 2023
@ahmedwaleedmalik ahmedwaleedmalik changed the title [Test] Fix CI Oct 20, 2023
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 20, 2023
@ahmedwaleedmalik ahmedwaleedmalik changed the title Fix CI Fix broken CI Oct 20, 2023
@ahmedwaleedmalik
Copy link
Member Author

/approve

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2023
@xrstf
Copy link
Contributor

xrstf commented Oct 20, 2023

kubernetes/test-infra#30400 seems to be the root cause for this.

@xrstf
Copy link
Contributor

xrstf commented Oct 20, 2023

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2023
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmedwaleedmalik,xrstf]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8ce8235813ff9a6db71d550f3b40d2cb7d46e55c

@ahmedwaleedmalik ahmedwaleedmalik added the kind/chore Updating grunt tasks etc; no production code changes. label Oct 20, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Oct 20, 2023
@kubermatic-bot kubermatic-bot merged commit 632c1b5 into kubermatic:main Oct 20, 2023
13 checks passed
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.8 milestone Oct 20, 2023
@ahmedwaleedmalik ahmedwaleedmalik deleted the fix-ci branch October 20, 2023 10:34
ahmedwaleedmalik added a commit to ahmedwaleedmalik/kubeone that referenced this pull request Oct 23, 2023
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
kubermatic-bot pushed a commit that referenced this pull request Oct 23, 2023
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants