-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken CI #2934
Fix broken CI #2934
Conversation
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
4e5dfde
to
8fbf516
Compare
/approve |
kubernetes/test-infra#30400 seems to be the root cause for this. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 8ce8235813ff9a6db71d550f3b40d2cb7d46e55c
|
Signed-off-by: Waleed Malik <ahmedwaleedmalik@gmail.com>
What this PR does / why we need it:
After our recent upgrade for prow https://github.com/kubermatic/infra/pull/2461, prow is no longer able to resolve symlinks for the job configurations.
Thanks to @xrstf we found that kubernetes/test-infra#30400 was the change that broke this. Removing the symlink in favor of copying the file(generated via code) fixes the issue.
Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
/kind chore
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: