Add markdown viewer #897
Merged
Add markdown viewer #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm Thanks a lot for pushing the PR for the next week's bug bash. |
avdaredevil
suggested changes
Mar 1, 2019
yebrahim
commented
Mar 1, 2019
|
/lgtm |
|
/approve |
yebrahim
force-pushed
the
markdown-viewer
branch
from
49366fa
to
9090b5b
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yebrahim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/test kubeflow-pipeline-e2e-test |
3 similar comments
|
/test kubeflow-pipeline-e2e-test |
|
/test kubeflow-pipeline-e2e-test |
|
/test kubeflow-pipeline-e2e-test |
|
/retest |
cheyang
pushed a commit
to alibaba/pipelines
that referenced
this pull request
Mar 28, 2019
* working, needs tests * tests * add output artifact loader tests * cleanup new experiment tests * pr comments
magdalenakuhn17
pushed a commit
to magdalenakuhn17/pipelines
that referenced
this pull request
Oct 22, 2023
* Fix up kfserving install doc link * Update quick install for 0.3.0 * Upgrade quick install to use istio 1.6.2 * Add perf test job for sklearn example * Add KFServing demo gif * Reorganize examples * Add feature descriptions * Add feature table for model serve * Add alibi references * Update main README * Add batcher/gRPC example * Fix perf job for sklearn example * separate custom predictor * Update batching and alibi * Add roadmap
HumairAK
pushed a commit
to red-hat-data-services/data-science-pipelines
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new viewer for markdown text, which supports both inlining the markdown or reading it from a remote storage. It uses markdown-it to convert the markdown text to HTML, and uses React's
dangerouslySetInnerHTMLmethod to insert it. We rely on the library's sanitization to make sure all active scripts are removed from the markdown. Basic component tests are added here as well.The PR also cleans up test files for NewExperiment, RecurringRunDetails, and RecurringRunsManager to reuse the mount tree, there's no change in functionality there, however, and they can be skipped in the review without leaving out much (so can their snapshot files).
@avdaredevil I'd appreciate it if you can review this PR, since @rileyjbauer is out.
This change is