Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change viewer to markdown instead of html according to FE changes. #895

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Change viewer to markdown instead of html according to FE changes. #895

merged 1 commit into from
Mar 5, 2019

Conversation

hongye-sun
Copy link
Contributor

@hongye-sun hongye-sun commented Mar 1, 2019 •
edited by jlewi
Loading

This change is Reviewable

@yebrahim
Copy link
Contributor

yebrahim commented Mar 1, 2019 •
edited
Loading

LGTM although I'd suggest waiting on #897 to merge before this, just so that we build a consistent end to end version.
/lgtm

@hongye-sun
Copy link
Contributor Author

sg. I will wait until PR #897 is in.

@yebrahim
Copy link
Contributor

yebrahim commented Mar 5, 2019

FYI that PR is merged.

@yebrahim
Copy link
Contributor

yebrahim commented Mar 5, 2019

/lgtm
/approve

@hongye-sun
Copy link
Contributor Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun, yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongye-sun, yebrahim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaoning777
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 806e123 into kubeflow:master Mar 5, 2019
cheyang pushed a commit to alibaba/pipelines that referenced this pull request Mar 28, 2019
@hongye-sun @k8s-ci-robot
Change viewer to markdown instead of html according to FE changes. (k…
c4cffc2 
…ubeflow#895)
Linchin pushed a commit to Linchin/pipelines that referenced this pull request Apr 11, 2023
Remove unnecessary tekton tasks (kubeflow#895)
50421a5 
Remove unnecessary tekton tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

@gaoning777 gaoning777 Awaiting requested review from gaoning777

Assignees

@yebrahim yebrahim

@gaoning777 gaoning777

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hongye-sun @yebrahim @k8s-ci-robot @gaoning777