pr comments

kubeflow · Mar 4, 2019 · 9090b5b · 9090b5b
1 parent 42f3fa8
commit 9090b5b
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 28 deletions.
diff --git a/frontend/src/components/viewers/MarkdownViewer.test.tsx b/frontend/src/components/viewers/MarkdownViewer.test.tsx
@@ -23,10 +23,11 @@ describe('MarkdownViewer', () => {
   let tree: ReactWrapper<any> | null;
 
   afterEach(() => {
-    if (tree) {
-      tree.unmount();
-      tree = null;
+    if (!tree) {
+      return;
     }
+    tree.unmount();
+    tree = null;
   });
 
   it('does not break on empty data', () => {
@@ -47,9 +48,9 @@ describe('MarkdownViewer', () => {
 
   it('sanitizes the markdown to remove XSS', () => {
     const markdown = `
-  lower[click me](javascript&#x3a;...)lower
-  upper[click me](javascript&#X3a;...)upper
-  `;
+      lower[click me](javascript&#x3a;...)lower
+      upper[click me](javascript&#X3a;...)upper
+    `;
     const config: MarkdownViewerConfig = {
       markdownContent: markdown,
       type: PlotType.MARKDOWN,

diff --git a/frontend/src/components/viewers/__snapshots__/MarkdownViewer.test.tsx.snap b/frontend/src/components/viewers/__snapshots__/MarkdownViewer.test.tsx.snap
@@ -36,9 +36,9 @@ exports[`MarkdownViewer sanitizes the markdown to remove XSS 1`] = `
     Array [
       Object {
         "markdownContent": "
-  lower[click me](javascript&#x3a;...)lower
-  upper[click me](javascript&#X3a;...)upper
-  ",
+      lower[click me](javascript&#x3a;...)lower
+      upper[click me](javascript&#X3a;...)upper
+    ",
         "type": "markdown",
       },
     ]
@@ -47,8 +47,9 @@ exports[`MarkdownViewer sanitizes the markdown to remove XSS 1`] = `
   <div
     dangerouslySetInnerHTML={
       Object {
-        "__html": "<p>lower[click me](javascript:...)lower
-upper[click me](javascript:...)upper</p>
+        "__html": "<pre><code>  lower[click me](javascript&amp;#x3a;...)lower
+  upper[click me](javascript&amp;#X3a;...)upper
+</code></pre>
 ",
       }
     }

diff --git a/package-lock.json b/package-lock.json