Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components - Upgraded TFJob version to v1 #2617

Closed
wants to merge 1 commit into from
Closed

Components - Upgraded TFJob version to v1 #2617

wants to merge 1 commit into from

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Nov 16, 2019 •
edited by jlewi
Loading

Fixes #2615

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ark-kun
You can assign the PR to them by writing /assign @ark-kun in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ark-kun Ark-kun mentioned this pull request Nov 16, 2019
Closed
@jessiezcc
Copy link
Contributor

/lgtm

ryandawsonuk
ryandawsonuk approved these changes Nov 16, 2019
View reviewed changes
Copy link
Contributor

@ryandawsonuk ryandawsonuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

There’s also some v1beta1 ones in the seldon examples but they can be tackled separately

hougangliu
hougangliu reviewed Nov 18, 2019
View reviewed changes
components/kubeflow/launcher/src/train.template.yaml
@@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

apiVersion: kubeflow.org/v1alpha2
apiVersion: kubeflow.org/v1
Copy link
Member

@hougangliu hougangliu Nov 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFjob cannot works if you only update here, some fields of tfjob CRD updated after v1alpha2
Refer to #1494
I can re-pick up #1494 for v1 if you hope me do that

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Dec 4, 2019

Closing in favor of #2677

@Ark-kun Ark-kun closed this Dec 4, 2019
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this pull request Oct 22, 2023
@alexagriffith
add model_ready v2 endpoint (kubeflow#2617)
9f2e6fe 
* add model ready v2

Signed-off-by: alexagriffith <agriffith50@bloomberg.net>

* lint

Signed-off-by: alexagriffith <agriffith50@bloomberg.net>

* add test back

Signed-off-by: alexagriffith <agriffith50@bloomberg.net>

Signed-off-by: alexagriffith <agriffith50@bloomberg.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hougangliu hougangliu hougangliu left review comments

@ryandawsonuk ryandawsonuk ryandawsonuk approved these changes

@gaoning777 gaoning777 Awaiting requested review from gaoning777

@hongye-sun hongye-sun Awaiting requested review from hongye-sun

Assignees

@ryandawsonuk ryandawsonuk

@jessiezcc jessiezcc

Labels
area/components lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TFJob version out of date
5 participants
@Ark-kun @k8s-ci-robot @jessiezcc @hougangliu @ryandawsonuk