Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFJob version out of date #2615

Closed
ryandawsonuk opened this issue Nov 15, 2019 · 6 comments
Closed

TFJob version out of date #2615

ryandawsonuk opened this issue Nov 15, 2019 · 6 comments
Assignees
Labels
area/components lifecycle/stale The issue / pull request is stale, any activities remove this label. status/wip

Comments

@ryandawsonuk
Copy link
Contributor

ryandawsonuk commented Nov 15, 2019

TFJob is now apiVersion: kubeflow.org/v1 - that's the version you get when you install kubeflow. Several components and examples still use v1alpha2 and v1beta1. With the new kubeflow you get an error if you try to deploy a TFJob of that version.

@jessiezcc
Copy link
Contributor

@jlewi to triage this one

@jlewi
Copy link
Contributor

jlewi commented Nov 16, 2019

@jessiezcc what's the question? TFJob went v1 in 0.6 I think. So examples and components should be updated.

@jessiezcc does someone on your team want to update the TFJob launcher or should we just delete it?

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 16, 2019

@jlewi Is there any place where I can see the API breaking changes for TFJob?
Otherwise I'll just bump the version.

@Ark-kun
Copy link
Contributor

Ark-kun commented Nov 16, 2019

TFJob is now apiVersion: kubeflow.org/v1 - that's the version you get when you install kubeflow. Several components and examples still use v1alpha2 and v1beta1. With the new kubeflow you get an error if you try to deploy a TFJob of that version.

Thanks for the report. I've bumped the TFJob version in the component. #2617

Do you think there are more changes needed when upgrading to v1?

@stale
Copy link

stale bot commented Jun 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jun 25, 2020
@stale
Copy link

stale bot commented Jul 2, 2020

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@stale stale bot closed this as completed Jul 2, 2020
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
Signed-off-by: rachitchauhan43 <rachitchauhan43@gmail.com>

Signed-off-by: rachitchauhan43 <rachitchauhan43@gmail.com>

Signed-off-by: rachitchauhan43 <rachitchauhan43@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/components lifecycle/stale The issue / pull request is stale, any activities remove this label. status/wip
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants