Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components - Upgraded TFJob version to v1 #2617

Closed
wants to merge 1 commit into from
Closed

Components - Upgraded TFJob version to v1 #2617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/kubeflow/launcher/src/train.template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

apiVersion: kubeflow.org/v1alpha2
apiVersion: kubeflow.org/v1
Copy link
Member

@hougangliu hougangliu Nov 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFjob cannot works if you only update here, some fields of tfjob CRD updated after v1alpha2
Refer to #1494
I can re-pick up #1494 for v1 if you hope me do that

kind: TFJob
metadata:
generateName: tfjob
Expand Down
2 changes: 1 addition & 1 deletion components/kubeflow/launcher/test/testdata/train.template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
apiVersion: kubeflow.org/v1alpha2
apiVersion: kubeflow.org/v1
kind: TFJob
metadata:
generateName: tfjob
Expand Down
2 changes: 1 addition & 1 deletion components/kubeflow/launcher/test/testdata/train_basic.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
apiVersion: kubeflow.org/v1alpha2
apiVersion: kubeflow.org/v1
kind: TFJob
metadata:
generateName: trainer-
Expand Down
2 changes: 1 addition & 1 deletion components/kubeflow/launcher/test/testdata/train_zero_worker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
apiVersion: kubeflow.org/v1alpha2
apiVersion: kubeflow.org/v1
kind: TFJob
metadata:
generateName: trainer-
Expand Down