Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Rule socket-communication-00000 not matching correctly #413

Closed
1 task done
jmle opened this issue Nov 9, 2023 · 1 comment · Fixed by konveyor/windup-shim#103
Closed
1 task done

[BUG] Rule socket-communication-00000 not matching correctly #413

jmle opened this issue Nov 9, 2023 · 1 comment · Fixed by konveyor/windup-shim#103
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@jmle
Copy link
Contributor

jmle commented Nov 9, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

0.3.0-beta2

Priority

Critical

Current Behavior

The rule does not match and issues are not created. If the "PACKAGE" location is removed, the rule matches.

Related to #363

Expected Behavior

The rule should match normally

How Reproducible

Always (Default)

Steps To Reproduce

Check #363 for steps on how to reproduce

Environment

Check https://github.com/konveyor/analyzer-lsp/issues/363 for environment

Anything else?

No response
@jmle jmle added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 9, 2023
@jmle jmle added this to Planning Nov 9, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Nov 9, 2023
@pranavgaikwad pranavgaikwad removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 15, 2023
@pranavgaikwad pranavgaikwad moved this from 🆕 New to 📋 Backlog in Planning Nov 15, 2023
@jmle jmle mentioned this issue Nov 28, 2023
Open
@jmle
Copy link
Contributor Author

jmle commented Nov 28, 2023

PACKAGE location does not seem to work as expected, probably all these locations should be switched with IMPORT... Created shim PR: konveyor/windup-shim#103

@jmle jmle mentioned this issue Dec 4, 2023
Merged
jmle added a commit to konveyor/windup-shim that referenced this issue Jan 3, 2024
@jmle
Convert to IMPORT instead of PACKAGE (#103)
c158c36 
Fixes konveyor/analyzer-lsp#413

---------

Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Planning Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
Planning
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert to IMPORT instead of PACKAGE jmle/windup-rulesets-yaml
2 participants
@jmle @pranavgaikwad