Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Missing rules (daytrader application) #363

Open
1 task done
jmle opened this issue Oct 6, 2023 · 0 comments
Open
1 task done

[BUG] Missing rules (daytrader application) #363

jmle opened this issue Oct 6, 2023 · 0 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@jmle
Copy link
Contributor

jmle commented Oct 6, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

0.3.0-alpha.5

Priority

Critical

Current Behavior

Some rules are appearing in windup, but for some reason not in konveyor:

Issue Rule ID
Local HTTP Calls localhost-http-00001
Windows file system path azure-os-specific-00001
jaxb-api' Maven dependency missing xml-java-versions-00001
jaxb-core' Maven dependency missing xml-java-versions-00002
jaxb-impl' Maven dependency missing xml-java-versions-00003
web.xml element references a javax-prefixed class name javax-to-jakarta-servlet-00130
java.sql.DriverManager type reference generic-catchall-00900
The application uses environment variables/system properties spring-boot-to-azure-system-config-01000
(.*) Maven dependency missing xml-java-versions-00001
Changes in ClassLoader hierarchy in JDK 11 may impact code java-removals-00150
web.xml element references a javax-prefixed class name javax-to-jakarta-servlet-00130
JSR 88 deployment plan not supported jboss-eap5and6to7-java-05000
Local JDBC Calls localhost-jdbc-00002
org.glassfish javax.faces artifactId has been replaced by org.glassfish jakarta.faces javax-to-jakarta-dependencies-00005
The incorrectly spelled javax.el.MethodExpression.isParmetersProvided() method has been removed jakarta-el-00010
Implementation or use by the application of the javax.xml.bind.Marshaller `getAdapter() method may need to be updated eap8-xml-binding-00009
Move to Jakarta EE Maven Artifacts - com.sun.mail:javax.mail maven-javax-to-jakarta-00001
File system - Java NIO local-storage-00005
Java Remote Method Invocation (RMI) API java-rmi-00001
Socket communication socket-communication-00000

It is possible that some of these rules missing are due to missing dependencies, so probably that issue should be solved first and then this table reassessed.

Expected Behavior

The rules being triggered should be similar to the windup report's ones.

How Reproducible

Always (Default)

Steps To Reproduce

  1. With the given environment, analyze the application with konveyor.
  2. Download all the application's dependencies into a folder by using mvn dependency:copy-dependencies
  3. Analyze the application and its dependencies with windup: ./windup-cli --target eap8 --target openjdk17 --target cloud-readiness --target quarkus --target camel --target azure-appservice --input ~/Dev/redhat/40SampleApps/sample.daytrader7 ~/Dev/redhat/40SampleApps/sample.daytrader7.dependencies --overwrite --analyzeKnownLibraries.
  4. Check that the issues mentioned previously don't appear in the konveyor report, but do appear in the windup one.

Environment

* Fedora 38
* minikube version: v1.31.2
* Konveyor 0.3.0-alpha.5
* [sample.daytrader7 app (master branch)](https://github.com/WASdev/sample.daytrader7)
* Analysis configuration:
** Source code + dependencies
** eap8, quarkus, openjdk17, azure, cloud-readiness
** Application and internal dependencies only/Application and all dependencies, including known Open Source libraries
** No custom rules
** No additional advanced options

Windup:
* Java 11
* Latest version of windup

Anything else?

No response

@jmle jmle added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 6, 2023
@pranavgaikwad pranavgaikwad removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 26, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Oct 26, 2023
@pranavgaikwad pranavgaikwad moved this from 🆕 New to 📋 Backlog in Planning Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants