-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to IMPORT instead of PACKAGE #103
Conversation
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
d92c774
to
95eaa69
Compare
Overall success rate: 80.25% (1897/2364) |
We need to make sure that this does cause other issues, like finding matches when it shouldn't. This was the initial reason to move to the package. IDK did how to do this systematically, but @pranavgaikwad did some great work putting it together. If this solves this, I will be happy, but did want to make sure that we don't flip-flop issues :) |
@shawn-hurley - java.referenced:
location: PACKAGE
pattern: java.net.(Socket|MulticastSocket|DatagramSocket|InetSocketAddress)* which doesn't make sense, since the reference is simply not a package, but a class. |
@shawn-hurley ...aaand then I just found this rule, which doesn't work with - java.referenced:
location: IMPORT
pattern: javax.enterprise.deploy* I'm thinking it could be worth issuing both an IMPORT and PACKAGE search whenever there is one of them, to be able we capture everything |
… PACKAGE Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
I think that, for now, we take this as is; IF we find more and more where it becomes a problem, I think we open a new one and figure out how to do both and then make sure that we can filter out the results that shouldn't match. |
I have merged it, although I guess that we'll have to see whether we want to keep using the shim for making changes in the rulesets, or if we want to change the rulesets directly instead. |
I think if we can we'll want to keep making changes to the shim, since that will also help users with custom rulesets |
Fixes konveyor/analyzer-lsp#413