[release-1.0] fix the latest_version function #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's aware of the new tag format and the manual jump from v0.26 => v1.0
knative-prow-robot
added
the
cla: yes
knative-prow-robot
added
the
size/M
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, knative-prow-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
lgtm
pierDipi
added a commit
to pierDipi/eventing-kafka-broker
that referenced
this pull request
Dec 6, 2021
We need knative/hack#106 Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
|
Hi @dprotaso, can you please trigger the upgrade dependencies workflow for the release-1.0 branch to bring this fix to every repository? 🙏 |
|
I'd just bump it manually for the repo(s) that you need. I did this for serving. You want to coordinate the cherry-pick with whatever fix you are looking to pull back. The CI auto-release unfortunately will always create a point release if there are any changes. So I don't want to make a change across all repos since it's not necessary |
|
They are a lot :( |
|
People can still close the PR if they don't want another point release. |
knative-prow-robot
pushed a commit
to knative-extensions/eventing-kafka-broker
that referenced
this pull request
Dec 6, 2021
* Add Broker Upgrade Tests (#617) Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com> * Remove useless TestMain Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com> * Upgrade knative.dev/hack to latest release-1.0 We need knative/hack#106 Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
pierDipi
added a commit
to pierDipi/eventing-kafka-broker
that referenced
this pull request
Dec 6, 2021
…ive-extensions#1552) * Add Broker Upgrade Tests (knative-extensions#617) Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com> * Remove useless TestMain Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com> * Upgrade knative.dev/hack to latest release-1.0 We need knative/hack#106 Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
pierDipi
added a commit
to pierDipi/eventing-kafka-broker
that referenced
this pull request
Dec 7, 2021
…ive-extensions#1552) * Add Broker Upgrade Tests (knative-extensions#617) Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com> * Remove useless TestMain Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com> * Upgrade knative.dev/hack to latest release-1.0 We need knative/hack#106 Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
knative-prow-robot
pushed a commit
to knative-extensions/eventing-kafka-broker
that referenced
this pull request
Dec 8, 2021
* Add Broker Upgrade Tests (#617) Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com> * Remove useless TestMain Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com> * Upgrade knative.dev/hack to latest release-1.0 We need knative/hack#106 Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
pierDipi
added a commit
to pierDipi/eventing-kafka-broker
that referenced
this pull request
Dec 9, 2021
…ive-extensions#1552) (knative-extensions#1573) * Add Broker Upgrade Tests (knative-extensions#617) Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com> * Remove useless TestMain Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com> * Upgrade knative.dev/hack to latest release-1.0 We need knative/hack#106 Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
openshift-merge-robot
pushed a commit
to openshift-knative/eventing-kafka-broker
that referenced
this pull request
Dec 10, 2021
… (knative-extensions#1573) (#59) * Add Broker Upgrade Tests (#617) Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com> * Remove useless TestMain Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com> * Upgrade knative.dev/hack to latest release-1.0 We need knative/hack#106 Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
mgencur
pushed a commit
to mgencur/eventing-kafka-broker
that referenced
this pull request
Dec 14, 2021
…ive-extensions#1552) * Add Broker Upgrade Tests (knative-extensions#617) Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com> * Remove useless TestMain Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com> * Upgrade knative.dev/hack to latest release-1.0 We need knative/hack#106 Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
openshift-merge-robot
pushed a commit
to openshift-knative/eventing-kafka-broker
that referenced
this pull request
Dec 14, 2021
… (#64) * Add Broker Upgrade Tests (#617) Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com> * Remove useless TestMain Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com> * Upgrade knative.dev/hack to latest release-1.0 We need knative/hack#106 Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com> Co-authored-by: Pierangelo Di Pilato <pdipilat@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #101