-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the latest_version function #101
fix the latest_version function #101
Conversation
it's aware of the new tag format and the manual jump from v0.26 => v1.0
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold - there's a bug |
/hold cancel |
/hold I'll verify in serving |
/hold cancel |
verified the behaviour
|
/lgtm |
I was wondering if using Github's function latest_version() {
local origin=$(git config --get remote.origin.url | sed 's/.*:\(.*\)\..*$/\1/')
curl -I -s https://github.com/${origin}/releases/latest | grep "location:" | awk -F/ '{print $NF}' | sed 's/ //g'
} |
looking https://docs.github.com/en/rest/reference/repos#get-the-latest-release - it's is sorted by but we need to sort by our semver versions since we'll produce newer patch releases for older branches |
/cherry-pick release-1.0 |
@dprotaso: new pull request created: #106 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-0.26 |
@dprotaso: #101 failed to apply on top of branch "release-0.26":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* fix the latest_version function it's aware of the new tag format and the manual jump from v0.26 => v1.0 * latest_version on the main branch will return the tag with the knative- prefix
it's aware of the new tag format and the manual jump from
v0.26 => v1.0
note: lates_version returns the tag which may now include prefixes