Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.0] Add Broker Upgrade Tests (#617) #1552

Conversation

pierDipi
Copy link
Member

Cherry-pick of: #617

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>

* Remove useless TestMain

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 29, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added area/test size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 29, 2021
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release-1.0@f4a3bf0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release-1.0    #1552   +/-   ##
==============================================
  Coverage               ?   76.39%           
  Complexity             ?      582           
==============================================
  Files                  ?       99           
  Lines                  ?     3575           
  Branches               ?      160           
==============================================
  Hits                   ?     2731           
  Misses                 ?      635           
  Partials               ?      209           
Flag Coverage Δ
java-unittests 82.02% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4a3bf0...0529481. Read the comment docs.

@pierDipi
Copy link
Member Author

Nov 29 15:33:02.375 install_latest_release [OUT] error: unable to read URL "https://github.com/knative-sandbox/eventing-kafka-broker/releases/download/v0.27.2/eventing-kafka-controller.yaml", server reported 404 Not Found, status code=404

We need knative/hack#106

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
@pierDipi
Copy link
Member Author

pierDipi commented Dec 6, 2021

/assign @mgencur @cardil

@mgencur
Copy link
Contributor

mgencur commented Dec 6, 2021

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2021
@knative-prow-robot knative-prow-robot merged commit 5e2f7e5 into knative-extensions:release-1.0 Dec 6, 2021
@pierDipi pierDipi deleted the release-1.0-upgrade-tests branch December 6, 2021 14:40
@pierDipi
Copy link
Member Author

pierDipi commented Dec 6, 2021

/cherry-pick release-0.26

@knative-prow-robot
Copy link
Contributor

@pierDipi: #1552 failed to apply on top of branch "release-0.26":

Applying: Add Broker Upgrade Tests (#617)
.git/rebase-apply/patch:2470: trailing whitespace.
[A]                                                                                                                           
.git/rebase-apply/patch:2595: trailing whitespace.
// 
.git/rebase-apply/patch:2598: trailing whitespace.
// 
.git/rebase-apply/patch:2602: trailing whitespace.
// 
.git/rebase-apply/patch:2603: trailing whitespace.
// 
warning: squelched 5 whitespace errors
warning: 10 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	go.sum
M	hack/tools.go
M	test/e2e-common.sh
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
CONFLICT (add/add): Merge conflict in test/e2e-upgrade-tests.sh
Auto-merging test/e2e-upgrade-tests.sh
Auto-merging test/e2e-common.sh
Auto-merging hack/tools.go
Auto-merging go.sum
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add Broker Upgrade Tests (#617)
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierDipi added a commit to pierDipi/eventing-kafka-broker that referenced this pull request Dec 6, 2021
…ive-extensions#1552)

* Add Broker Upgrade Tests (knative-extensions#617)

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>

* Remove useless TestMain

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>

* Upgrade knative.dev/hack to latest release-1.0

We need knative/hack#106

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
pierDipi added a commit to pierDipi/eventing-kafka-broker that referenced this pull request Dec 7, 2021
…ive-extensions#1552)

* Add Broker Upgrade Tests (knative-extensions#617)

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>

* Remove useless TestMain

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>

* Upgrade knative.dev/hack to latest release-1.0

We need knative/hack#106

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
knative-prow-robot pushed a commit that referenced this pull request Dec 8, 2021
* Add Broker Upgrade Tests (#617)

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>

* Remove useless TestMain

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>

* Upgrade knative.dev/hack to latest release-1.0

We need knative/hack#106

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
pierDipi added a commit to pierDipi/eventing-kafka-broker that referenced this pull request Dec 9, 2021
…ive-extensions#1552) (knative-extensions#1573)

* Add Broker Upgrade Tests (knative-extensions#617)

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>

* Remove useless TestMain

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>

* Upgrade knative.dev/hack to latest release-1.0

We need knative/hack#106

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
openshift-merge-robot pushed a commit to openshift-knative/eventing-kafka-broker that referenced this pull request Dec 10, 2021
… (knative-extensions#1573) (#59)

* Add Broker Upgrade Tests (#617)

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>

* Remove useless TestMain

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>

* Upgrade knative.dev/hack to latest release-1.0

We need knative/hack#106

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
mgencur pushed a commit to mgencur/eventing-kafka-broker that referenced this pull request Dec 14, 2021
…ive-extensions#1552)

* Add Broker Upgrade Tests (knative-extensions#617)

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>

* Remove useless TestMain

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>

* Upgrade knative.dev/hack to latest release-1.0

We need knative/hack#106

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
openshift-merge-robot pushed a commit to openshift-knative/eventing-kafka-broker that referenced this pull request Dec 14, 2021
… (#64)

* Add Broker Upgrade Tests (#617)

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>

* Remove useless TestMain

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>

* Upgrade knative.dev/hack to latest release-1.0

We need knative/hack#106

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>

Co-authored-by: Pierangelo Di Pilato <pdipilat@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants