feat: autocreate v1beta3 eventtypes #8276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cali0707 <calumramurray@gmail.com>
Signed-off-by: Cali0707 <calumramurray@gmail.com>
… et autocreate handler Signed-off-by: Cali0707 <calumramurray@gmail.com>
knative-prow
bot
added
the
size/L
knative-prow
bot
added
the
approved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8276 +/- ##
==========================================
- Coverage 65.55% 65.08% -0.47%
==========================================
Files 371 374 +3
Lines 22913 23109 +196
==========================================
+ Hits 15020 15040 +20
- Misses 7102 7278 +176
Partials 791 791 ☔ View full report in Codecov by Sentry. |
pierDipi
approved these changes
Oct 25, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
matzew
reviewed
Oct 25, 2024
| {Name: "source", Value: source.String(), Required: true}, | ||
| {Name: "schemadata", Value: schema.String(), Required: true}, | ||
| {Name: "specversion", Value: event.SpecVersion(), Required: true}, | ||
| {Name: "id", Required: false}, |
There was a problem hiding this comment.
Ah my bad, I'll open a quick follow up :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8098
Proposed Changes
Pre-review Checklist
Release Note