Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventType AutoCreate: set the specversion and id fields on the eventtypes #8098

Closed
Cali0707 opened this issue Jul 11, 2024 · 13 comments · Fixed by #8276
Closed

EventType AutoCreate: set the specversion and id fields on the eventtypes #8098

Cali0707 opened this issue Jul 11, 2024 · 13 comments · Fixed by #8276
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request

Comments

@Cali0707
Copy link
Member

Cali0707 commented Jul 11, 2024

Problem
We recently moved to reconciling the v1beta3 eventtypes, but the eventtype autocreate code is still creating the v1beta2 resources. We should switch to creating v1beta3 resources and setting the specversion field to be the cloudevents spec version of the event that triggered the autocreate, as well as setting the id field on the eventtype (but with no value)

Persona:
Which persona is this feature for?

Exit Criteria
The eventtype autocreate feature successfully create v1beta3 eventtypes and all existing e2e tests still pass

Time Estimate (optional):
How many developer-days do you think this may take to resolve? 1

Additional context (optional)
Add any other context about the feature request here.

@Cali0707
Copy link
Member Author

/help

Copy link

knative-prow bot commented Jul 11, 2024

@Cali0707:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 11, 2024
@Cali0707 Cali0707 changed the title EventType AutoCreate: set the spec and id fields on the eventtypes EventType AutoCreate: set the specversion and id fields on the eventtypes Jul 11, 2024
@iyoshiha
Copy link

I'd like to take care of this problem. Could you please assign it to me?

@Cali0707
Copy link
Member Author

/assign @iyoshiha

@matzew
Copy link
Member

matzew commented Jul 16, 2024

@iyoshiha how is it going? Can we help you?

@iyoshiha
Copy link

@iyoshiha how is it going? Can we help you?

@matzew Thank you for your concern. I haven't started working on the problem yet. I will start today and report my progress later.

@matzew
Copy link
Member

matzew commented Jul 17, 2024

@iyoshiha sounds good! You can also chat w/ us on the upstream slack channel for #knative-eventing

@iyoshiha
Copy link

@matzew hi sorry for the late report. I'm currently facing issues with E2E tests not working properly. I'll keep trying to get it to work. However, if you want to resolve this issue quickly, it might be better to assign it to someone else.

@iyoshiha
Copy link

iyoshiha commented Jul 22, 2024

@matzew Actually, I was able to pass the test on the main branch. So, I will work on the parts that actually need to be modified. It will probably take a day or two and I can make a PR.

@matzew
Copy link
Member

matzew commented Jul 24, 2024

sure. let use know if you need help. Also review on PR will help to polish the request to go in.

Thanks

@iyoshiha
Copy link

@matzew I apologize for my late response due to illness. I will prepare the PR.

@rahulii
Copy link
Contributor

rahulii commented Sep 5, 2024

/assign

@matzew
Copy link
Member

matzew commented Sep 18, 2024

@rahulii thanks for showing interest! If you need help. Just let us know, either here or on the slack channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants