-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EventType AutoCreate: set the specversion
and id
fields on the eventtypes
#8098
Comments
/help |
@Cali0707: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
spec
and id
fields on the eventtypesspecversion
and id
fields on the eventtypes
I'd like to take care of this problem. Could you please assign it to me? |
/assign @iyoshiha |
@iyoshiha how is it going? Can we help you? |
@iyoshiha sounds good! You can also chat w/ us on the upstream slack channel for |
@matzew hi sorry for the late report. I'm currently facing issues with E2E tests not working properly. I'll keep trying to get it to work. However, if you want to resolve this issue quickly, it might be better to assign it to someone else. |
@matzew Actually, I was able to pass the test on the main branch. So, I will work on the parts that actually need to be modified. It will probably take a day or two and I can make a PR. |
sure. let use know if you need help. Also review on PR will help to polish the request to go in. Thanks |
@matzew I apologize for my late response due to illness. I will prepare the PR. |
/assign |
@rahulii thanks for showing interest! If you need help. Just let us know, either here or on the slack channel |
Problem
We recently moved to reconciling the v1beta3 eventtypes, but the eventtype autocreate code is still creating the v1beta2 resources. We should switch to creating v1beta3 resources and setting the
specversion
field to be the cloudevents spec version of the event that triggered the autocreate, as well as setting theid
field on the eventtype (but with no value)Persona:
Which persona is this feature for?
Exit Criteria
The eventtype autocreate feature successfully create v1beta3 eventtypes and all existing e2e tests still pass
Time Estimate (optional):
How many developer-days do you think this may take to resolve? 1
Additional context (optional)
Add any other context about the feature request here.
The text was updated successfully, but these errors were encountered: