Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: et autocreate makes eventtype id required #8288

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix: et autocreate makes eventtype id required #8288

merged 1 commit into from
Oct 28, 2024

Conversation

Cali0707
Copy link
Member

@Cali0707 Cali0707 commented Oct 25, 2024 •
edited
Loading

Follow up on #8276 (comment)

Proposed Changes

  • EventTypes autocreated have the id attribute required

@Cali0707
fix: et autocreate makes eventtype id required
19c0d1c 
Signed-off-by: Cali0707 <calumramurray@gmail.com>
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 25, 2024
@knative-prow knative-prow bot requested review from aliok and aslom October 25, 2024 15:49
@Cali0707
Copy link
Member Author

/cc @matzew @pierDipi

@codecov Codecov
Copy link

codecov bot commented Oct 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.08%. Comparing base (65aeab5) to head (19c0d1c).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8288   +/-   ##
=======================================
  Coverage   65.08%   65.08%           
=======================================
  Files         374      374           
  Lines       23109    23109           
=======================================
  Hits        15040    15040           
  Misses       7278     7278           
  Partials      791      791

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

matzew
matzew approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Oct 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit ef6b31a into knative:main Oct 28, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@aliok aliok Awaiting requested review from aliok

@aslom aslom Awaiting requested review from aslom

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cali0707 @matzew