Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eventing TLS: Test ApiServerSource with eventshub TLS receiver as sink #6956

Merged
merged 1 commit into from
May 23, 2023
Merged

Eventing TLS: Test ApiServerSource with eventshub TLS receiver as sink #6956

merged 1 commit into from
May 23, 2023

Conversation

pierDipi
Copy link
Member

Fixes #6913

Proposed Changes

  • Test ApiServerSource with eventshub TLS receiver as sink

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

ApiServerSource supports sending events to TLS endpoints, minimum TLS version is v1.2

Docs

@knative-prow knative-prow bot added the area/test-and-release Test infrastructure, tests or release label May 18, 2023
@knative-prow knative-prow bot requested review from evankanderson and mgencur May 18, 2023 10:25
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 18, 2023
@pierDipi pierDipi changed the title Eventing TLS: Test ApiServerSource with eventshub TLS receiver as sink [WIP] Eventing TLS: Test ApiServerSource with eventshub TLS receiver as sink May 18, 2023
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 18, 2023
This was referenced May 18, 2023
Closed
Closed
Closed
@codecov
Copy link

codecov bot commented May 18, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (b47b4ec) 79.82% compared to head (caac118) 79.81%.

❗ Current head caac118 differs from pull request most recent head 6a41031. Consider uploading reports for the commit 6a41031 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6956      +/-   ##
==========================================
- Coverage   79.82%   79.81%   -0.01%     
==========================================
  Files         244      244              
  Lines       12791    12788       -3     
==========================================
- Hits        10210    10207       -3     
  Misses       2075     2075              
  Partials      506      506

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pierDipi pierDipi force-pushed the apiserversource-tls branch from d7c6b50 to b656232 Compare May 18, 2023 11:31
@pierDipi
Copy link
Member Author

/test upgrade-tests

@pierDipi
Copy link
Member Author

Test fix in knative-extensions/reconciler-test#530

@pierDipi pierDipi force-pushed the apiserversource-tls branch from b656232 to f2ebd61 Compare May 19, 2023 10:52
@knative-prow
Copy link

knative-prow bot commented May 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi pierDipi mentioned this pull request May 19, 2023
Merged
5 tasks
@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 19, 2023
@pierDipi pierDipi changed the title [WIP] Eventing TLS: Test ApiServerSource with eventshub TLS receiver as sink Eventing TLS: Test ApiServerSource with eventshub TLS receiver as sink May 22, 2023
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 22, 2023
@pierDipi
Eventing TLS: Test ApiServerSource with eventshub TLS receiver as sink
6a41031 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi force-pushed the apiserversource-tls branch from caac118 to 6a41031 Compare May 23, 2023 09:59
@pierDipi
Copy link
Member Author

/cc @matzew @creydr @gabo1208 @vishal-chdhry

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 23, 2023
@pierDipi
Copy link
Member Author

I had to rebase because of conflicts, please take a look

@vishal-chdhry
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2023
@knative-prow knative-prow bot merged commit b81082c into knative:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@mgencur mgencur Awaiting requested review from mgencur

@creydr creydr Awaiting requested review from creydr

@gabo1208 gabo1208 Awaiting requested review from gabo1208

@matzew matzew Awaiting requested review from matzew

@vishal-chdhry vishal-chdhry Awaiting requested review from vishal-chdhry

Assignees

@vishal-chdhry vishal-chdhry

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eventing TLS: Test ApiServerSource with eventshub TLS receiver as sink
2 participants
@pierDipi @vishal-chdhry