Eventing TLS: Test ContainerSource with eventshub TLS receiver as sink #6957

vishal-chdhry · 2023-05-18T12:36:51Z

Proposed Changes

Test ContainerSource with eventshub TLS receiver as sink

Pre-review Checklist

At least 80% unit test coverage
E2E tests for any new behavior
Docs PR for any user-facing impact
Spec PR for any new API feature
Conformance test for any change to the spec

Release Note

ContainerSource supports sending events to TLS endpoints, minimum TLS version is v1.2

Docs

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

test/rekt/resources/containersource/containersource_test.go

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

pierDipi · 2023-05-19T10:54:22Z

We need this fix to get the test to pass knative-extensions/reconciler-test#530, in addition, I've updated the PR to make it "work" #6956, like CA certs indentation for the resource, CRD update to include CACerts field, etc

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

codecov · 2023-05-19T14:36:54Z

Codecov Report

Patch and project coverage have no change.

Comparison is base (4adc287) 79.80% compared to head (68ff134) 79.80%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6957   +/-   ##
=======================================
  Coverage   79.80%   79.80%           
=======================================
  Files         244      244           
  Lines       12793    12793           
=======================================
  Hits        10209    10209           
  Misses       2078     2078           
  Partials      506      506

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

## Proposed Changes - 🎁 Provide the underlying channels CACerts in the Brokers status as an annotation (`knative.dev/channelCACerts`). Similar as the channelsAddress is provided in the `knative.dev/channelAddress` annoation. --------- Signed-off-by: Christoph Stäbler <cstabler@redhat.com>

Cron -knative-prow-robot /cc knative/eventing-writers /assign knative/eventing-writers Produced by: knative-sandbox/knobots/actions/update-deps Signed-off-by: Knative Automation <automation@knative.team>

Fixes knative#6963  ## Proposed Changes  - use EventType v1b2 on sources `duck` controller/reconciler - updating reconciler testing for v1b2, adding listers/factory ### Pre-review Checklist  - [ ] **At least 80% unit test coverage** - [ ] **E2E tests** for any new behavior - [ ] **Docs PR** for any user-facing impact - [ ] **Spec PR** for any new API feature - [ ] **Conformance test** for any change to the spec **Release Note**  ```release-note EventType v1b2 on sources `duck` controller/reconciler used ``` **Docs**  Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

pierDipi · 2023-05-23T14:36:20Z

@vishal-chdhry I think you need to rebase/merge main because there are quite a few unrelated changes

vishal-chdhry · 2023-05-23T14:57:37Z

@pierDipi done

test/rekt/resources/containersource/containersource_test.go

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

test/rekt/resources/containersource/containersource.yaml

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

vishal-chdhry · 2023-05-23T17:21:10Z

/test reconciler-tests

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

test/rekt/container_source_test.go

pierDipi · 2023-05-24T08:47:01Z

test/rekt/features/containersource/features.go

+	f.Stable("containersource as event source").
+		Must("delivers events",
+			assert.OnStore(sink).MatchEvent(
+				test.HasType("dev.knative.eventing.samples.heartbeat"),


TLS tests and your PR made me realize this: knative-extensions/reconciler-test#535, so technically, this match might match events that are "rejected" so travelling in plaintext on non TLS connection, therefore, for the time being, we need the MatchKind call, similar to APIServerSource TLS test:

eventing/test/rekt/features/apiserversource/data_plane.go

Lines 203 to 206 in 5e245ac

eventasssert.OnStore(sink).

Match(eventasssert.MatchKind(eventshub.EventReceived)).

MatchEvent(test.HasType("dev.knative.apiserver.resource.update")).

AtLeast(1),

I added the matching, all the events were of type "rejected"

Ok, that's a nice finding, I believe we need to add CACerts to the SinkBinding resources (similar to changes in config/core/resources/containersource.yaml) since ContainerSource uses SinkBinding under the hood, so if CACerts is not propagated to it, it won't work

pierDipi

Thanks @vishal-chdhry, I left a few suggestions but it looks good!

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

vishal-chdhry · 2023-05-24T14:18:01Z

/test unit-tests

pierDipi

/lgtm
/approve

knative-prow · 2023-05-24T15:06:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, Vishal-Chdhry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pierDipi · 2023-05-24T15:06:30Z

Thanks!

pierDipi · 2023-05-24T15:06:46Z

/retest-required

replaced ref with destination

81e0abd

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/test-and-release Test infrastructure, tests or release size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 18, 2023

knative-prow bot requested review from evankanderson and mgencur May 18, 2023 12:37

feature test

05bee6b

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

vishal-chdhry commented May 18, 2023

View reviewed changes

test/rekt/resources/containersource/containersource_test.go Show resolved Hide resolved

knative-prow bot requested a review from pierDipi May 18, 2023 12:56

vishal-chdhry added 2 commits May 18, 2023 18:28

fixed linting issues

1ebda57

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

NIT

32cf9f3

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

vishal-chdhry changed the title ~~[WIP] Eventing TLS: Test ContainerSource with eventshub TLS receiver as sink~~ Eventing TLS: Test ContainerSource with eventshub TLS receiver as sink May 18, 2023

knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 18, 2023

requested changes

d09bf05

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

vishal-chdhry and others added 4 commits May 20, 2023 10:17

NIT

fcffaf8

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

[main] Upgrade to latest dependencies (knative#6958)

971ab80

Cron -knative-prow-robot /cc knative/eventing-writers /assign knative/eventing-writers Produced by: knative-sandbox/knobots/actions/update-deps Signed-off-by: Knative Automation <automation@knative.team>

knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 23, 2023

vishal-chdhry added 4 commits May 23, 2023 15:59

test

4f5a155

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

added type

15aa530

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

NIT

128b00b

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

updated SendEventsWithTLSRecieverAsSink

e4e481e

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

Merge branch 'main' into container-source-tls-test

e18d312

knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 23, 2023

pierDipi reviewed May 23, 2023

View reviewed changes

test/rekt/resources/containersource/containersource_test.go Outdated Show resolved Hide resolved

fixed namespace tests

59f80c4

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

vishal-chdhry requested a review from pierDipi May 23, 2023 15:33

fix example-full

2d21cce

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

vishal-chdhry commented May 23, 2023

View reviewed changes

test/rekt/resources/containersource/containersource.yaml Outdated Show resolved Hide resolved

pierDipi reviewed May 23, 2023

View reviewed changes

test/rekt/resources/containersource/containersource.yaml Outdated Show resolved Hide resolved

fixed ExampleFull

1be808f

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

vishal-chdhry added 3 commits May 24, 2023 08:31

updated tests

f3daab1

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

channel tests

b465a32

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

DeadLetterSink test

4a99bb1

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

vishal-chdhry requested a review from pierDipi May 24, 2023 08:41

pierDipi reviewed May 24, 2023

View reviewed changes

test/rekt/container_source_test.go Outdated Show resolved Hide resolved

pierDipi reviewed May 24, 2023

View reviewed changes

vishal-chdhry added 3 commits May 24, 2023 15:41

added match kind

6693024

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

suggestion from pier

5c7b0a7

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

added cacert to sink binding

68ff134

Signed-off-by: Vishal Choudhary <sendtovishalchoudhary@gmail.com>

pierDipi approved these changes May 24, 2023

View reviewed changes

knative-prow bot assigned pierDipi May 24, 2023

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2023

knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2023

knative-prow bot merged commit 390a0c8 into knative:main May 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Eventing TLS: Test ContainerSource with eventshub TLS receiver as sink #6957

Eventing TLS: Test ContainerSource with eventshub TLS receiver as sink #6957

vishal-chdhry commented May 18, 2023

pierDipi commented May 19, 2023

codecov bot commented May 19, 2023 •

edited

Loading

pierDipi commented May 23, 2023

vishal-chdhry commented May 23, 2023

vishal-chdhry commented May 23, 2023

pierDipi May 24, 2023 •

edited

Loading

vishal-chdhry May 24, 2023

pierDipi May 24, 2023

pierDipi left a comment

vishal-chdhry commented May 24, 2023

pierDipi left a comment

knative-prow bot commented May 24, 2023

pierDipi commented May 24, 2023

pierDipi commented May 24, 2023

	eventasssert.OnStore(sink).
	Match(eventasssert.MatchKind(eventshub.EventReceived)).
	MatchEvent(test.HasType("dev.knative.apiserver.resource.update")).
	AtLeast(1),

Eventing TLS: Test ContainerSource with eventshub TLS receiver as sink #6957

Eventing TLS: Test ContainerSource with eventshub TLS receiver as sink #6957

Conversation

vishal-chdhry commented May 18, 2023

Proposed Changes

Pre-review Checklist

pierDipi commented May 19, 2023

codecov bot commented May 19, 2023 • edited Loading

Codecov Report

pierDipi commented May 23, 2023

vishal-chdhry commented May 23, 2023

vishal-chdhry commented May 23, 2023

pierDipi May 24, 2023 • edited Loading

Choose a reason for hiding this comment

vishal-chdhry May 24, 2023

Choose a reason for hiding this comment

pierDipi May 24, 2023

Choose a reason for hiding this comment

pierDipi left a comment

Choose a reason for hiding this comment

vishal-chdhry commented May 24, 2023

pierDipi left a comment

Choose a reason for hiding this comment

knative-prow bot commented May 24, 2023

pierDipi commented May 24, 2023

pierDipi commented May 24, 2023

codecov bot commented May 19, 2023 •

edited

Loading

pierDipi May 24, 2023 •

edited

Loading