Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eventing TLS: Test SinkBinding with eventshub TLS receiver as sink #6916

Closed
pierDipi opened this issue May 5, 2023 · 7 comments · Fixed by #6979
Closed

Eventing TLS: Test SinkBinding with eventshub TLS receiver as sink #6916

pierDipi opened this issue May 5, 2023 · 7 comments · Fixed by #6979
Assignees
@taniaduggal
Labels
area/test-and-release Test infrastructure, tests or release good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request

Comments

@pierDipi
Copy link
Member

pierDipi commented May 5, 2023

Problem

We need to have a e2e test for SinkBinding with eventshub TLS receiver (to be added in #6842)

Exit Criteria

A rekt-based e2e test for SinkBinding TLS support (to be added in #6915)

Time Estimate (optional):
1

Additional context (optional)

/good-first-issue
@knative-prow
Copy link

knative-prow bot commented May 5, 2023

@pierDipi:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Problem

We need to have a e2e test for SinkBinding with eventshub TLS receiver (to be added in #6842)

Exit Criteria

A rekt-based e2e test for SinkBinding TLS support (to be added in #6915)

Time Estimate (optional):
1

Additional context (optional)

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels May 5, 2023
@pierDipi pierDipi moved this to 📋 Backlog in Eventing TLS May 5, 2023
@taniaduggal
Copy link
Contributor

/assign

@taniaduggal
Copy link
Contributor

I have to make e2e test-cases under test/e2e folder or i have to make changes in the sinkbinding and eventhub receiver related files? If right, can you give hint in which files?
and correct me if i am wrong @pierDipi

@pierDipi
Copy link
Member Author

pierDipi commented May 8, 2023 •
edited
Loading

Hi @taniaduggal, this issue depends on on 2 other issues that are not implemented yet (#6915 and #6842) so it's not ready to be worked on actively, however, regarding the files to modify / take a look, see SinkBinding tests:

so we need a new test called TestSinkBindingV1DeploymentTLS that is similar to TestSinkBindingV1Deployment and lives in the same file but uses the feature implemented in #6842 of the eventshub receiver.

@pierDipi pierDipi added the area/test-and-release Test infrastructure, tests or release label May 8, 2023
@pierDipi pierDipi moved this from 📋 Backlog to 🔖 Ready in Eventing TLS May 18, 2023
@pierDipi
Copy link
Member Author

pierDipi commented May 18, 2023 •
edited
Loading

This is ready to be implemented.

I've provided an example PR on how to implement TLS tests for sources in #6956, so based on that code a SinkBinding test can be implementated in a similar way

@pierDipi
Copy link
Member Author

@taniaduggal let me know if that helps or how can I help you

@taniaduggal
Copy link
Contributor

I have my exams going on, will soon make a pr by tomorrow or the next day, thanks :)

@taniaduggal taniaduggal mentioned this issue May 22, 2023
Closed
@pierDipi pierDipi moved this from 🔖 Ready to 🏗 In progress in Eventing TLS May 23, 2023
@taniaduggal taniaduggal mentioned this issue May 25, 2023
Merged
@pierDipi pierDipi moved this from 🏗 In progress to 👀 In review in Eventing TLS May 31, 2023
knative-prow bot pushed a commit that referenced this issue Jun 9, 2023
@taniaduggal @pierDipi
test SinkBinding with eventshub TLS receiver as sink (#6979)
3267b1a 
Fixes #6916

---------

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Eventing TLS Jun 9, 2023
vishal-chdhry pushed a commit to vishal-chdhry/eventing that referenced this issue Jul 6, 2023
@taniaduggal @pierDipi @vishal-chdhry
test SinkBinding with eventshub TLS receiver as sink (knative#6979)
4d6b0b1 
Fixes knative#6916

---------

Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taniaduggal taniaduggal

Labels
area/test-and-release Test infrastructure, tests or release good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request
Projects
No open projects
Eventing TLS
Status: ✅ Done
Milestone
No milestone
2 participants
@pierDipi @taniaduggal