-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test SinkBinding with eventshub TLS receiver as sink #6961
Conversation
Signed-off-by: Tania Duggal <103496926+taniaduggal@users.noreply.github.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: taniaduggal The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @taniaduggal. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pierDipi have you checked others files as well? Are they good or i have to make changes accordingly |
@taniaduggal I will review them again once we make the changes and the CI jobs are green, they look good for now! |
Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
/ok-to-test |
@pierDipi some tests are failing |
Yes, I see @taniaduggal have you looked into them ?
it seems there is a compilation error |
@taniaduggal I think this commit might fix your issue: ce077af, also please rebase the PR on top of the latest main branch |
@taniaduggal: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Fixes #6916