Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test SinkBinding with eventshub TLS receiver as sink #6961

Closed
wants to merge 4 commits into from
Closed

test SinkBinding with eventshub TLS receiver as sink #6961

wants to merge 4 commits into from

Conversation

taniaduggal
Copy link
Contributor

Fixes #6916

Signed-off-by: Tania Duggal <103496926+taniaduggal@users.noreply.github.com>
@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/test-and-release Test infrastructure, tests or release labels May 22, 2023
@knative-prow
Copy link

knative-prow bot commented May 22, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: taniaduggal
Once this PR has been reviewed and has the lgtm label, please assign cardil for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from evankanderson and mgencur May 22, 2023 13:17
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 22, 2023
@knative-prow
Copy link

knative-prow bot commented May 22, 2023

Hi @taniaduggal. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@taniaduggal
Copy link
Contributor Author

@pierDipi have you checked others files as well? Are they good or i have to make changes accordingly

@pierDipi
Copy link
Member

pierDipi commented May 23, 2023

@taniaduggal I will review them again once we make the changes and the CI jobs are green, they look good for now!

@pierDipi pierDipi self-requested a review May 23, 2023 09:53
Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@taniaduggal taniaduggal marked this pull request as ready for review May 23, 2023 11:21
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 23, 2023
@vishal-chdhry
Copy link
Member

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 23, 2023
@taniaduggal
Copy link
Contributor Author

@pierDipi some tests are failing

@pierDipi
Copy link
Member

pierDipi commented May 24, 2023

Yes, I see @taniaduggal have you looked into them ?


=== Errors
test/rekt/resources/sinkbinding/sinkbinding.go:133:24: syntax error: unexpected = at end of statement
test/rekt/resources/sinkbinding/sinkbinding.go:139:5: syntax error: non-declaration statement outside function body

it seems there is a compilation error

@pierDipi
Copy link
Member

@taniaduggal I think this commit might fix your issue: ce077af, also please rebase the PR on top of the latest main branch

@knative-prow
Copy link

knative-prow bot commented May 25, 2023

@taniaduggal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_eventing_main b750660 link true /test unit-tests
build-tests_eventing_main b750660 link true /test build-tests
reconciler-tests_eventing_main b750660 link true /test reconciler-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@taniaduggal taniaduggal closed this by deleting the head repository May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test-and-release Test infrastructure, tests or release ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eventing TLS: Test SinkBinding with eventshub TLS receiver as sink
3 participants