Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more explicit about the semantic of ceOverrides #5641

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

lionelvillard
Copy link
Member

Proposed Changes

  • Make it explicit in the source spec that ceOverrides cannot override required CE attribute. Optional attributes can be specified/overridden.

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

:broom: Clarify the semantic of `ceOverrides`

Docs

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 18, 2021
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 18, 2021
@lionelvillard
Copy link
Member Author

/cc @n3wscott @antoineco

@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #5641 (97e84cc) into main (c183833) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5641   +/-   ##
=======================================
  Coverage   82.73%   82.73%           
=======================================
  Files         200      200           
  Lines        6266     6266           
=======================================
  Hits         5184     5184           
  Misses        750      750           
  Partials      332      332           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c183833...97e84cc. Read the comment docs.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2021
@antoineco
Copy link
Contributor

/lgtm

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: antoineco, lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [antoineco,lionelvillard]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 5c08bd3 into knative:main Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants