Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be more explicit about the semantic of ceOverrides #5641

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Be more explicit about the semantic of ceOverrides #5641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion docs/spec/sources.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ ducktype. Additional data in spec and status is explicitly permitted.

### duck.Spec

The `spec` field is expected to have the following minimum shape:
The `spec` field is MUST have the following minimum shape:

```go
type SourceSpec struct {
Expand All @@ -307,6 +307,11 @@ type SourceSpec struct {
}
```

When `spec.ceOverrides.extensions` is specified and non-empty, the event sent to
the sink is augmented or modified with the specified _extension_ attributes. The
source controller MUST reject extensions overriding the
[required Cloud Events attributes](https://github.com/cloudevents/spec/blob/v1.0.1/spec.md#required-attributes).

For a golang structure definition of `Sink` and `CloudEventsOverrides`, please
see
[Destination](https://pkg.go.dev/github.com/knative/pkg/apis/duck/v1?tab=doc#Destination),
Expand Down