Skip to content

Commit

Permalink
be more explicit about the semantic of ceOverrides (#5641)
Browse files Browse the repository at this point in the history
  • Loading branch information
lionelvillard authored Aug 18, 2021
1 parent c183833 commit 5c08bd3
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion docs/spec/sources.md
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ ducktype. Additional data in spec and status is explicitly permitted.

### duck.Spec

The `spec` field is expected to have the following minimum shape:
The `spec` field is MUST have the following minimum shape:

```go
type SourceSpec struct {
Expand All @@ -307,6 +307,11 @@ type SourceSpec struct {
}
```

When `spec.ceOverrides.extensions` is specified and non-empty, the event sent to
the sink is augmented or modified with the specified _extension_ attributes. The
source controller MUST reject extensions overriding the
[required Cloud Events attributes](https://github.com/cloudevents/spec/blob/v1.0.1/spec.md#required-attributes).

For a golang structure definition of `Sink` and `CloudEventsOverrides`, please
see
[Destination](https://pkg.go.dev/github.com/knative/pkg/apis/duck/v1?tab=doc#Destination),
Expand Down

0 comments on commit 5c08bd3

Please sign in to comment.