-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix broken in-mem channel namespace mode #4906
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4906 +/- ##
==========================================
+ Coverage 81.14% 81.63% +0.49%
==========================================
Files 294 294
Lines 8383 8393 +10
==========================================
+ Hits 6802 6852 +50
+ Misses 1175 1135 -40
Partials 406 406
Continue to review full report at Codecov.
|
}, | ||
}, | ||
}, { | ||
Name: "CONTAINER_NAME", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where did CONTAINER_NAME
come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/test pull-knative-eventing-integration-tests |
1 similar comment
/test pull-knative-eventing-integration-tests |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vaikas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
/cherry-pick release-0.21 |
@pierDipi: new pull request created: #5029 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-0.20 |
@pierDipi: #4906 failed to apply on top of branch "release-0.20":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes #4844
Proposed Changes
Release Note
Docs