Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken in-mem channel namespace mode #4906

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

lionelvillard
Copy link
Member

Fixes #4844

Proposed Changes

  • Fix privilege escalation error
  • Fix missing env vars in namespace-scoped in-mem dispatcher.

Release Note

:bug: Fix bug preventing the namespace-scoped in-memory channel to become ready. 

Docs

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 22, 2021
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 22, 2021
@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #4906 (bd2e963) into master (4e5bdf9) will increase coverage by 0.49%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4906      +/-   ##
==========================================
+ Coverage   81.14%   81.63%   +0.49%     
==========================================
  Files         294      294              
  Lines        8383     8393      +10     
==========================================
+ Hits         6802     6852      +50     
+ Misses       1175     1135      -40     
  Partials      406      406              
Impacted Files Coverage Δ
...inmemorychannel/controller/resources/dispatcher.go 100.00% <100.00%> (ø)
pkg/apis/flows/v1/parallel_validation.go 100.00% <0.00%> (+100.00%) ⬆️
pkg/apis/flows/v1beta1/parallel_validation.go 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e5bdf9...bd2e963. Read the comment docs.

},
},
}, {
Name: "CONTAINER_NAME",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did CONTAINER_NAME come from?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lionelvillard
Copy link
Member Author

/test pull-knative-eventing-integration-tests

1 similar comment
@lionelvillard
Copy link
Member Author

/test pull-knative-eventing-integration-tests

@vaikas
Copy link
Contributor

vaikas commented Mar 2, 2021

/lgtm
/approve
/hold
in case @n3wscott has more questions.

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2021
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2021
@n3wscott
Copy link
Contributor

n3wscott commented Mar 2, 2021

/unhold
Sorry, I was just having a driveby question

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2021
@knative-prow-robot knative-prow-robot merged commit 4282f45 into knative:master Mar 2, 2021
@pierDipi
Copy link
Member

pierDipi commented Mar 8, 2021

/cherry-pick release-0.21
/cherry-pick release-0.20

@knative-prow-robot
Copy link
Contributor

@pierDipi: new pull request created: #5029

In response to this:

/cherry-pick release-0.21
/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi
Copy link
Member

pierDipi commented Mar 8, 2021

/cherry-pick release-0.20

@knative-prow-robot
Copy link
Contributor

@pierDipi: #4906 failed to apply on top of branch "release-0.20":

Applying: fix broken in-mem ns mode
Using index info to reconstruct a base tree...
M	pkg/reconciler/inmemorychannel/controller/resources/dispatcher.go
M	pkg/reconciler/inmemorychannel/controller/resources/dispatcher_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/reconciler/inmemorychannel/controller/resources/dispatcher_test.go
CONFLICT (content): Merge conflict in pkg/reconciler/inmemorychannel/controller/resources/dispatcher_test.go
Auto-merging pkg/reconciler/inmemorychannel/controller/resources/dispatcher.go
CONFLICT (content): Merge conflict in pkg/reconciler/inmemorychannel/controller/resources/dispatcher.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix broken in-mem ns mode
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

single tenant IMC missing RBAC for the leases
5 participants