💄 adding check for -1 status code for the default impl (#4897)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
knative · Feb 19, 2021 · 4e5bdf9 · 4e5bdf9
1 parent 403aefa
commit 4e5bdf9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/kncloudevents/message_sender.go b/pkg/kncloudevents/message_sender.go
@@ -162,7 +162,7 @@ func RetryConfigFromDeliverySpec(spec duckv1.DeliverySpec) (RetryConfig, error)
 
 // Simple default implementation
 func RetryIfGreaterThan300(_ context.Context, response *nethttp.Response, err error) (bool, error) {
-	return !(response != nil && (response.StatusCode < 300)), err
+	return !(response != nil && (response.StatusCode < 300 && response.StatusCode != -1)), err
 }
 
 // Alternative function to determine whether to retry based on response

diff --git a/pkg/kncloudevents/message_sender_test.go b/pkg/kncloudevents/message_sender_test.go
@@ -336,7 +336,7 @@ func TestRetryIfGreaterThan300(t *testing.T) {
 		{
 			name:     "Http StatusCode -1",
 			response: &http.Response{StatusCode: -1},
-			result:   false,
+			result:   true,
 		},
 		{
 			name:     "Http StatusCode 100",