Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding check for -1 status code for the default retry impl #4897

Merged

Conversation

matzew
Copy link
Member

@matzew matzew commented Feb 19, 2021

Signed-off-by: Matthias Wessendorf mwessend@redhat.com

Fixes #

Proposed Changes

  • Adding a try if the statusCode is -1, similar to the new alternative/approach

Release Note

We now do a retry if we have a -1 statusCode

Docs

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Feb 19, 2021
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 19, 2021
@matzew
Copy link
Member Author

matzew commented Feb 19, 2021

/assign @slinkydeveloper

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #4897 (9ebe809) into master (403aefa) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4897   +/-   ##
=======================================
  Coverage   81.14%   81.14%           
=======================================
  Files         294      294           
  Lines        8383     8383           
=======================================
  Hits         6802     6802           
  Misses       1175     1175           
  Partials      406      406           
Impacted Files Coverage Δ
pkg/kncloudevents/message_sender.go 82.25% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 403aefa...9ebe809. Read the comment docs.

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew matzew force-pushed the add_negative_one_retry_check branch from 1d868f6 to 9ebe809 Compare February 19, 2021 09:56
@antoineco antoineco changed the title Adding check for -1 status code for the default impl Adding check for -1 status code for the default retry impl Feb 19, 2021
@slinkydeveloper
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slinkydeveloper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2021
@knative-prow-robot knative-prow-robot merged commit 4e5bdf9 into knative:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants