fix broken in-mem ns mode

knative · Feb 22, 2021 · bd2e963 · bd2e963
1 parent 4e5bdf9
commit bd2e963
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 0 deletions.
diff --git a/config/channels/in-memory-channel/roles/controller-clusterrole.yaml b/config/channels/in-memory-channel/roles/controller-clusterrole.yaml
@@ -35,6 +35,14 @@ rules:
       - inmemorychannels/finalizers
     verbs:
       - update
+  - apiGroups:
+      - messaging.knative.dev
+    resources:
+      - inmemorychannels/finalizers
+      - inmemorychannels/status
+      - inmemorychannels
+    verbs:
+      - patch
   - apiGroups:
       - ""
     resources:

diff --git a/pkg/reconciler/inmemorychannel/controller/resources/dispatcher.go b/pkg/reconciler/inmemorychannel/controller/resources/dispatcher.go
@@ -128,6 +128,16 @@ func makeEnv(dispatcherConfig config.EventDispatcherConfig) []corev1.EnvVar {
 				FieldPath: "metadata.namespace",
 			},
 		},
+	}, {
+		Name: "POD_NAME",
+		ValueFrom: &corev1.EnvVarSource{
+			FieldRef: &corev1.ObjectFieldSelector{
+				FieldPath: "metadata.name",
+			},
+		},
+	}, {
+		Name:  "CONTAINER_NAME",
+		Value: "dispatcher",
 	}, {
 		Name:  "MAX_IDLE_CONNS",
 		Value: strconv.Itoa(dispatcherConfig.MaxIdleConns),

diff --git a/pkg/reconciler/inmemorychannel/controller/resources/dispatcher_test.go b/pkg/reconciler/inmemorychannel/controller/resources/dispatcher_test.go
@@ -102,6 +102,16 @@ func TestNewDispatcher(t *testing.T) {
 										FieldPath: "metadata.namespace",
 									},
 								},
+							}, {
+								Name: "POD_NAME",
+								ValueFrom: &corev1.EnvVarSource{
+									FieldRef: &corev1.ObjectFieldSelector{
+										FieldPath: "metadata.name",
+									},
+								},
+							}, {
+								Name:  "CONTAINER_NAME",
+								Value: "dispatcher",
 							}, {
 								Name:  "MAX_IDLE_CONNS",
 								Value: "2000",